Bug 19733 - [content assist] Code assist closes when the list would filter to 0 items
Summary: [content assist] Code assist closes when the list would filter to 0 items
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 enhancement with 12 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 82440 277037 (view as bug list)
Depends on:
Blocks: 317704
  Show dependency tree
 
Reported: 2002-06-09 04:56 EDT by Ron Baldwin CLA
Modified: 2016-06-22 09:00 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Baldwin CLA 2002-06-09 04:56:42 EDT
Code assist closes when the list would filter to 0 items.  This means, for
example, that mistyping a method name will close code assist forcing you to
reopen it after backspacing over the incorrect character.

A better approach would be to jump to the entries in the list as you type
instead of filtering the list.  This would have the following advantages:
   1) Mistyping does not close code assist.  Simply backspace and type the
correct charater and code assist will continue to follow.
   2) If you begin typing something (a method name for example) then realize
that you don't remember the name of what you are looking for, you can just
scroll through the list.  Currently, you have to completely backspace over what
you typed (to restore all filtered items) and then scroll through the list.
   3) Should also be faster as eclipse does not have to keep regenerating the
list -- it only has to select the first item that matches what you have typed so
far.

This is how Visual Studio 6 implements code assist, which I have found to be
very useful and unobtrusive.
Comment 1 Ron Baldwin CLA 2002-06-09 05:55:47 EDT
I just discovered that tab sets focus to the code assist window, allowing you to
type to jump to an item without causing the list to filter or go away.  However,
this suffers from the following problems:

   1) You have to press tab to set focus to the list before typing the item you
are looking for.  The goal of code assist is to save keystrokes, which this does
not do.
   2) You can't Shift+Tab back out of the list.  This means that if you want to
get your caret back and have code assist open, you have to press Esc to close
code assist (to get your caret back) then reopen code assist.
   3) You have no feedback as you type.
   4) If you mistype, you either have to stop typing for a moment or hit an
arrow key (so it will start searching from the beginning of the words again),
then retype from the beginning.  This would not be an issue if the code assist
window simply tracked what you typed, as you could just backspace over the
incorrect character and continue typing.
Comment 2 Erich Gamma CLA 2002-06-09 14:21:27 EDT
we will not change this for 2.0. Both approaches (filtering, selecting) are 
useful. We could consider surfacing a preference after 2.0
Comment 3 Dirk Baeumer CLA 2002-07-17 14:21:00 EDT
What's about simply not closing code assist if the list filters to o items ?
Comment 4 Dirk Baeumer CLA 2002-07-24 06:43:20 EDT
Reopening for 2.1 consideration
Comment 5 Dani Megert CLA 2005-01-11 05:06:03 EST
*** Bug 82440 has been marked as a duplicate of this bug. ***
Comment 6 Dani Megert CLA 2009-05-20 02:37:01 EDT
*** Bug 277037 has been marked as a duplicate of this bug. ***
Comment 7 Scott Evans CLA 2009-05-20 12:44:54 EDT
I just unknowningly opened a dupe of this (bug 277037). I'd like to see support for this added to the platform at the API level; adding a pref in core Eclipse would be nice too.
Comment 8 Dani Megert CLA 2009-05-20 13:13:15 EDT
>I'd like to see support
>for this added to the platform at the API level; adding a pref in core Eclipse
>would be nice too.
What do you think is the difference between the two?

We won't work on this until we get a patch.
Comment 9 Scott Evans CLA 2009-05-20 13:21:52 EDT
(In reply to comment #8)
> >I'd like to see support
> >for this added to the platform at the API level; adding a pref in core Eclipse
> >would be nice too.
>
> What do you think is the difference between the two?

Even if Eclipse doesn't expose a pref that affects all code assist, an API level change  (along the lines of what I was suggesting in that dupe bug) would let me change code assist behavior in our app. (Right?)

 
> We won't work on this until we get a patch.

I'll see if I can carve out some time in a month or two.
Comment 10 Dani Megert CLA 2009-05-20 14:07:49 EDT
> an API level change  
This is not an option. The API has to be kept stable.
Comment 11 Eclipse Genie CLA 2016-02-13 17:32:51 EST
New Gerrit change created: https://git.eclipse.org/r/66555
Comment 12 Rahul Rajavel CLA 2016-02-19 02:09:13 EST
I came across this bug and think I have found a solution. I have submitted a patch that I think addresses this in the most straightforward manner. Please take a look at the Gerrit change and let me know what you think. Thank you.
Comment 13 Eclipse Genie CLA 2016-03-28 20:15:11 EDT
New Gerrit change created: https://git.eclipse.org/r/69389
Comment 14 Rahul Rajavel CLA 2016-03-28 20:25:45 EDT
I have posted a solution in the gerrit link above.
Comment 15 Dani Megert CLA 2016-03-29 03:32:26 EDT
(In reply to Eclipse Genie from comment #13)
> New Gerrit change created: https://git.eclipse.org/r/69389

I've abandoned that change. Please upload the new version to the original change: https://git.eclipse.org/r/#/c/66555/ so that previous review comments are in the same change.