Bug 274255 - [Perspectives] [perfs] Big regression on 'UI - Open/Close Performance Test Perspective' test
Summary: [Perspectives] [perfs] Big regression on 'UI - Open/Close Performance Test Pe...
Status: RESOLVED DUPLICATE of bug 262636
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 RC1   Edit
Assignee: Eric Moffatt CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-04-29 05:01 EDT by Frederic Fusier CLA
Modified: 2009-05-11 05:08 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2009-04-29 05:01:28 EDT 
Since build N20090424-1216, the scenario OpenClosePerspectiveTest#testOpenClosePerspectives:org.eclipse.ui.tests.performancePerspective1() 
has got a big performance regression.

Looking at the Status Table, it seems to be the same for *all* perspective scenarios...
Comment 1 Frederic Fusier CLA 2009-04-29 05:05:27 EDT 
It seems that there's also an impact on other scenarios, typically
OpenCloseViewTest#showView:org.eclipse.ui.navigator.ProjectExplorer() which
also got a regression since N20090424-1216...
Comment 2 Dani Megert CLA 2009-04-29 05:07:58 EDT 
Maybe a regression opening the Project Explorer?
Comment 3 Paul Webster CLA 2009-04-29 07:46:39 EDT 
On possibility, Bug 273066

PW
Comment 4 Eric Moffatt CLA 2009-04-29 08:34:34 EDT 
Perspective activation now performs a full update on both the main menu and the CoolBar. Also we may have (temporarily) have introduced a lazy loading regression (see bug 262636).

Paul, is there any way to get around the lazy loading issue without losing the update completely?
Comment 5 Oleg Besedin CLA 2009-04-30 12:10:50 EDT 
I can confirm that change in the bug 262636 added significant regression to this test.

CPU time:
with change for the bug 273066 reversed:	 75ms; 
with the change:				290ms. 

That's about 300% increase on my Win XP machine.
Comment 6 Oleg Besedin CLA 2009-04-30 12:12:37 EDT 
(In reply to comment #5)
> I can confirm that change in the bug 262636 added significant regression to
> this test.
That should be bug 273066.
Comment 7 Paul Webster CLA 2009-05-01 08:10:48 EDT 
The bugs Oleg mentions also cause flashing during perspective switching.

Should we consider backing them out for M7?

PW
Comment 8 Dani Megert CLA 2009-05-01 08:50:32 EDT 
>Should we consider backing them out for M7?
Nothing is seriously broken, so I think it's good enough if we make sure to take a close look during RC1.
Comment 9 Eric Moffatt CLA 2009-05-01 09:33:08 EDT 
Will do, thanks Dani
Comment 10 Boris Bokowski CLA 2009-05-06 16:38:41 EDT 
ping
Comment 11 Paul Webster CLA 2009-05-07 07:45:50 EDT 
We'll be looking at this as part of bug 262636

PW
Comment 12 Eric Moffatt CLA 2009-05-07 13:41:27 EDT 
Paul, we seem to be able to avoid the 'flashing' during the perspective switch simply by not updating the TB's in the Perspective's 'onActivate'. They still appear to behave normally (i.e. I can have two different sets of hidden tool items in two perspectives and switching between them updates the TB's in a manner consistent with the overrides.
Comment 13 Eric Moffatt CLA 2009-05-07 15:32:55 EDT 
Marking as a DUP since the results are on the other defect...


*** This bug has been marked as a duplicate of bug 262636 ***