Bug 273066 - [Contributions] [CPD] Customizing a perspective affects other perspecitve
Summary: [Contributions] [CPD] Customizing a perspective affects other perspecitve
Status: RESOLVED DUPLICATE of bug 262636
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-21 10:08 EDT by Markus Schorn CLA
Modified: 2009-05-04 15:36 EDT (History)
2 users (show)

See Also:

Attachments
Update the action bars during a perspective switch (781 bytes, patch)
2009-04-23 12:39 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Schorn CLA 2009-04-21 10:08:58 EDT 
To reproduce:
* Open to perspectives (e.g. Java + Debug) and make sure that in both 
  perspectives you have the menu item 'Open Type...'. You can do the
  same testcase with 'Open Resource...'.
* In one perspective use 'Customize Perspective - Menu Visibility' to hide
  the menu item. 
* Switch to the other perspective, the menu item is gone. I expect it to be
  there.
* If you look into 'Customize Perspective - Menu Visibility', you'll see that
  the menu item is selected (although it is not shown).
Comment 1 Eric Moffatt CLA 2009-04-23 10:55:13 EDT 
Markus, which build are you using? 

I've just tried this using I20090313-0100 by hiding 'Open Type' in the Debug perspective and then switching back and forth between it and the Java perspective and it was always there in the Java perspective and not there in the Debug.
Comment 2 Markus Schorn CLA 2009-04-23 11:08:27 EDT 
(In reply to comment #1)
> Markus, which build are you using? 
> I've just tried this using I20090313-0100 by hiding 'Open Type' in the Debug
> perspective and then switching back and forth between it and the Java
> perspective and it was always there in the Java perspective and not there in
> the Debug.

Hmm, I am using Version: 3.5.0 Build id: I20090313-0100
I'll try to reproduce in a workspace created from scratch later today.
Comment 3 Eric Moffatt CLA 2009-04-23 11:13:14 EDT 
Hmmm, weirdness...I hate weirdness...;-). Let me know how it goes.
Comment 4 Markus Schorn CLA 2009-04-23 11:15:40 EDT 
I can reproduce this with a new (and thus empty) workspace:

* Open eclipse, I am in the Java perspective
* Open debug perspective
* Hide 'Open Type...'
* Go back to Java perspective, 'Open Type...' is gone, :-(.
Comment 5 Eric Moffatt CLA 2009-04-23 11:18:10 EDT 
OK, my turn...;-).
Comment 6 Eric Moffatt CLA 2009-04-23 11:23:59 EDT 
Yep, I'm seeing it now too...I'm taking a deeper look now that I can repro...
Comment 7 Markus Schorn CLA 2009-04-23 11:26:02 EDT 
(In reply to comment #6)
> Yep, I'm seeing it now too...I'm taking a deeper look now that I can repro...

Ok, thanks. By the way, it's a very nice and useful feature.
Comment 8 Eric Moffatt CLA 2009-04-23 12:39:01 EDT 
Created attachment 132973 [details]
Update the action bars during a perspective switch


Does the trick. I've verified that WorkbenchPage#resetToolBarLayout is only called once during a perspective switch (i.e. it wasn't just a case of an ordering issue, the menu and TB weren't being refreshed when switching perspectives).
Comment 9 Eric Moffatt CLA 2009-04-23 12:40:56 EDT 
Committed in >2009042. Now update the action bars on perspective activation.

Good pickup Markus, thanks !
Comment 10 Eric Moffatt CLA 2009-04-30 14:00:05 EDT 
This fix is to be reviewed in RC1...see Bug 262636.
Comment 11 Eric Moffatt CLA 2009-04-30 14:01:47 EDT 
Changing target...
Comment 12 Eric Moffatt CLA 2009-04-30 14:02:24 EDT 

*** This bug has been marked as a duplicate of bug 262636 ***
Comment 13 Eric Moffatt CLA 2009-05-04 15:36:35 EDT 
Clearing milestone since it's a DUP...