Community
Participate
Working Groups
Not yet in HEAD, reproducible on branch_20090126_LocalDiff branch When creating a patch for local files (valid IFiles) we should use the Patch Root options available in the wizard (Workspace, Project, Selection) instead of the newly added "Use only file path".
Fixing this issue makes the request from bug 270473 invalid.
So, what you mean is, that the wizard should: - use and make available options "Workspace", "Project", "Selection" when comaparing IFiles, - use and make available option "Use only file path" when comaparing diffrent objects (like local history, repository files or other variants) , right ?
Yes.
Created attachment 130430 [details] Patch_v1 Patch resolving this issue.
Created attachment 130431 [details] Tests_v1 Patch for the tests required after Patch_v1.
Thanks for the patch Krzysztof, it looks like a step in the right direction. However I've got some comments: 1. First of all, I would fix bug 270569 prior this one, to clean up the code. 2. I would change "Use only file path" to something more appropriate, imo even "Custom root path" sounds better. 3. Since you decided to keep "Use only file path" option for IFiles, even though it's disabled I think the text in it should be different. Initially, for Workspace I would display there a valid workspace path, with "/" at the beginning. Once user changes the selection, you could also update the text accordingly. This would make it work and look more less as Enter Module Name page in the Share Wizard. 4. What's the meaning of org.eclipse.compare.internal.GenerateDiffFileWizard.OptionsPage.performSpecificActions() method? 5. I would not process the root path in the UDF, is it possible to make it the wizard? This way you won't have to pass the wizard's internals (constants) to the UDF. Once you update the patch I will give another shot.
We've got the updated patch, with all the issues fixed, but we now wait for approval of patch for bug 270569 and it's release for branch. It is necessarily to adjust patch for this bug to match the changes made in patch for bug 270569.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
