Bug 270131 - Create Patch always shows an error dialog
Summary: Create Patch always shows an error dialog
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 270476 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-26 11:25 EDT by Markus Keller CLA
Modified: 2009-04-01 06:05 EDT (History)
9 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-03-26 11:25:50 EDT 
I20090325-1135

Create Patch always shows an error dialog:

Title: Problem Occurred
Message: org.eclipse.core.expressions: The server did not provide any additional information.

Steps:
- check out org.eclipse.core.expressions from :pserver:anonymous@dev.eclipse.org:/cvsroot/eclipse
- open ElementHandler.java\
- add a space
- save
- Team > Create Patch
- Finish
=> Error dialog

However, the patch that ends up in the clipboard looks complete to me.

The error is probably only surfaced now due to the fix for bug 267817. In I20090317-1745, I don't get an error dialog, but the CVS console shows the same error.
Comment 1 Markus Keller CLA 2009-03-26 11:28:00 EDT 
CCing the webmaster. Did anything change in the CVS installation on dev.eclipse.org recently?
Comment 2 Dani Megert CLA 2009-03-26 11:53:38 EDT 
The fix for bug 267817 is completely  broken because the cvs diff command (in contrast to all other commands) returns 0 if there was no change and some other number if there was a diff or if there was an error. I suggest to read a CVS manual for upcoming fixes to cvs stuff ;-)

Also, it looks like the "fix" was never tested carefully.
Comment 3 Dani Megert CLA 2009-03-26 11:58:28 EDT 
Can you please add "Create Patch" and "Apply Patch" to your smoke test? Thanks.
Comment 4 Tomasz Zarna CLA 2009-03-26 12:46:33 EDT 
The fix for bug 267817 has been reverted and the bug has been reopened. Sorry guys.
Comment 5 Szymon Brandys CLA 2009-03-26 12:47:50 EDT 
(In reply to comment #3)
> Can you please add "Create Patch" and "Apply Patch" to your smoke test? Thanks.

We do manual tests, however they are not sufficient. What we need are good automated tests. We plan to add them during M7, see bug 266812.
Comment 6 Olivier Thomann CLA 2009-03-26 12:49:13 EDT 
Is the patch still usable ?
I created many patches despite this problem and I hope I can use them safely.
Comment 7 Dani Megert CLA 2009-03-26 12:51:23 EDT 
>We do manual tests, however they are not sufficient.
Right, that was my point ;-) Creating and applying a patch are essential operations that must be part of the manual (smoke) test pass which has to be done before each integration build input is made.

>Is the patch still usable ?
Yes, the patch is fine.
Comment 8 Szymon Brandys CLA 2009-03-30 13:06:11 EDT 
*** Bug 270476 has been marked as a duplicate of this bug. ***
Comment 9 Pawel Pogorzelski CLA 2009-04-01 06:05:03 EDT 
(In reply to comment #6)
> Is the patch still usable ?
> I created many patches despite this problem and I hope I can use them safely.
> 

Yes, you can.