Bug 266812 - [Tests] Add tests for creating/applying patches from UI
Summary: [Tests] Add tests for creating/applying patches from UI
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-03 03:55 EST by Szymon Brandys CLA
Modified: 2009-06-02 07:14 EDT (History)
0 users

See Also:

Attachments
Patch_v01 (10.42 KB, patch)
2009-04-07 10:09 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (12.54 KB, patch)
2009-04-07 11:15 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v03 (13.89 KB, patch)
2009-04-09 05:16 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Patch_B_v01 (20.20 KB, patch)
2009-04-09 05:55 EDT, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_B_v02 (20.07 KB, patch)
2009-04-09 08:18 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Patch_B_v03 (629 bytes, patch)
2009-04-14 17:09 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2009-03-03 03:55:52 EST 
We have to add tests to check creating/applying patches using appropriate patch dialogs. It seems that our current tests check only API, however as we noticed during some recent NBuilds this is not enough.
Comment 1 Szymon Brandys CLA 2009-03-26 12:48:37 EDT 
See bug 270131 for the case to cover in the tests.
Comment 2 Pawel Pogorzelski CLA 2009-04-07 10:09:07 EDT 
Created attachment 131127 [details]
Patch_v01

Test for applying a patch using the wizard.
Comment 3 Pawel Pogorzelski CLA 2009-04-07 11:15:24 EDT 
Created attachment 131136 [details]
Patch_v02

I added a test to apply a patch from the clipboard.
Comment 4 Szymon Brandys CLA 2009-04-09 05:10:53 EDT 
The test look fine. 

I think that UITest could be renamed to PatchUITest. AFAIK some util methods to handle UI tests will be duplicated in compare.tests, cvs.tests. I would try to create one common util class available for all team/compare tests, but this would require a new bug and further investigation during 3.6.
Comment 5 Pawel Pogorzelski CLA 2009-04-09 05:16:42 EDT 
Created attachment 131383 [details]
Patch_v03

(In reply to comment #4)
> I think that UITest could be renamed to PatchUITest. 
> <text deleted/>

Done. Also added a few minor changes.
Comment 6 Szymon Brandys CLA 2009-04-09 05:27:35 EDT 
Patch_v03 released to HEAD.
Comment 7 Pawel Pogorzelski CLA 2009-04-09 05:55:47 EDT 
Created attachment 131386 [details]
Patch_B_v01

Another test for creating a patch through a wizard.
Comment 8 Pawel Pogorzelski CLA 2009-04-09 08:18:43 EDT 
Created attachment 131388 [details]
Patch_B_v02

Patch_B with fixed concurrency issues.
Comment 9 Szymon Brandys CLA 2009-04-09 08:36:09 EDT 
Patch_B_v02 released to HEAD.

Finally we have UI tests for creating/applying patches. Pawel, please verify that everything is in and mark the bug FIXED.
Comment 10 Pawel Pogorzelski CLA 2009-04-09 09:00:42 EDT 
I've checked the HEAD and it's fine. Marking as FIXED.
Comment 11 Pawel Pogorzelski CLA 2009-04-14 17:09:34 EDT 
Created attachment 131851 [details]
Patch_B_v03

I forgot to add a folder to "bin.includes" property. This causes the tests to fail on the build machines but causes no trouble when running them from the workspace.
Comment 12 Szymon Brandys CLA 2009-04-15 04:15:26 EDT 
Patch_B_v03 released to HEAD.