Bug 268253 - [Wizards] Support keywords in new wizard
Summary: [Wizards] Support keywords in new wizard
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Prakash Rangaraj CLA
QA Contact: Prakash Rangaraj CLA
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 296801 296802 296803
  Show dependency tree
 
Reported: 2009-03-11 22:07 EDT by Nitin Dahyabhai CLA
Modified: 2009-12-17 02:07 EST (History)
6 users (show)

See Also:


Attachments
Patch v01 (29.42 KB, patch)
2009-12-02 03:30 EST, Prakash Rangaraj CLA
no flags Details | Diff
Screenshot (27.72 KB, image/png)
2009-12-02 03:32 EST, Prakash Rangaraj CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2009-03-11 22:07:41 EDT
3.5M5

Currently I have a wizard for JSP files simply named "JSP", which is the proper acronym for "JavaServer Page" and how most people refer to them.  I can't expand the wizard name, however, to the proper name without losing the ability for users to actually type "jsp" into the search field and find the wizard.  The only solutions I can think of either involve supporting the keywords extension point with newWizards or supporting camel case in the search field, which would solve this problem for anyone else dealing with acronyms.
Comment 1 Dani Megert CLA 2009-03-13 03:33:13 EDT
Good idea (see also bug 268310).
Comment 2 Dani Megert CLA 2009-05-25 10:34:58 EDT
I think the right way is to do the same as in the preference page i.e. support to specify keywords.

Camel case filtering would probably better implemented in org.eclipse.ui.dialogs.PatternFilter.
Comment 3 Dani Megert CLA 2009-06-22 10:14:55 EDT
Same should be done for Import/Export wizard.
Comment 4 Boris Bokowski CLA 2009-11-26 16:20:49 EST
Prakash is now responsible for watching bugs in the [Wizards] component area.
Comment 5 Prakash Rangaraj CLA 2009-12-02 03:30:25 EST
Created attachment 153566 [details]
Patch v01

Adding the keyword support to new/import/export wizards. Not sure whether CamelCasing is really useful here. So didn't to that part
Comment 6 Prakash Rangaraj CLA 2009-12-02 03:32:18 EST
Created attachment 153567 [details]
Screenshot

Sample usage
Comment 7 Prakash Rangaraj CLA 2009-12-02 03:34:33 EST
Adding Boris for comments
Comment 8 Dani Megert CLA 2009-12-02 03:40:14 EST
>Not sure whether CamelCasing is really useful here. So didn't to that part
Good. This would be inconsistent as we also don't have this in other wizards and dialogs (except in the 'Open XY' ones).
Comment 9 Boris Bokowski CLA 2009-12-02 09:34:54 EST
(In reply to comment #7)
> Adding Boris for comments

looks good!
Comment 10 Prakash Rangaraj CLA 2009-12-02 12:00:47 EST
Patch v01 released to HEAD
Comment 11 Prakash Rangaraj CLA 2009-12-08 02:08:50 EST
Verified in I20091207-1300
Comment 12 Dani Megert CLA 2009-12-09 09:32:46 EST
>Verified in I20091207-1300
How did you verify it? I could not find a keyword contribution in I20091207-1300.
Comment 13 Prakash Rangaraj CLA 2009-12-09 12:07:13 EST
(In reply to comment #12)
> How did you verify it? I could not find a keyword contribution in
> I20091207-1300.

By writing a sample plugin with keywords for the wizards and running it.
Comment 14 John Arthorne CLA 2009-12-11 15:48:37 EST
In the screenshot it shows "zip" as a keyword for the archive import wizard. This makes a lot of sense to me - shouldn't we go through our existing wizards and add some reasonable keywords?

I just noticed this now, but it would have made a good N&N entry - I'm adding the keyword so that we can consider this for the M5 N&N if we add some new keywords for our existing wizards.
Comment 15 Prakash Rangaraj CLA 2009-12-11 23:36:00 EST
(In reply to comment #14)
> In the screenshot it shows "zip" as a keyword for the archive import wizard.
> This makes a lot of sense to me - shouldn't we go through our existing wizards
> and add some reasonable keywords?

John,

   You may want to look at Bug #296801, Bug #296802 & Bug #296803.

> I just noticed this now, but it would have made a good N&N entry - I'm adding
> the keyword so that we can consider this for the M5 N&N if we add some new
> keywords for our existing wizards.

   I thought of making an N&N entry, but then what good is a feature from Platform UI, when Platform UI itself didn't use :-) Once those three bugs are fixed, it would be a good candidate for M5 N&N.
Comment 16 Dani Megert CLA 2009-12-14 03:30:10 EST
Agree with previous comment.
Comment 17 Prakash Rangaraj CLA 2009-12-17 02:07:39 EST
*** Bug 138121 has been marked as a duplicate of this bug. ***