Community
Participate
Working Groups
Provide an implementation of TaskEditorExtensionSettingsContribution (bug 244650) for configuring the task editor extension, e.g. for WikiText.
Created attachment 116737 [details] screenshot
A couple of thought from reviewing the UI: It's better to avoid the forms look and feel in dialogs, it is inconsistent with "native" controls (see Linux screenshot). I believe the only reason the FormToolkit is used in the dialog is for expandable composites but I am not even that is strictly needed so it maybe a good idea to remove it from the API all together. I have looked for other examples in the Eclipse UI where a bold font is used to indicate the default but could not find any. I think appending "(default)" is sufficient to highlight the default option. On first sight I found it difficult to figure out how to disable the extension. It was not obvious to me that "Plain Text" does this. How about replacing the first option by an "Enable" checkbox?
(In reply to comment #2) > It's better to avoid the forms look and feel in dialogs, it is inconsistent with > "native" controls (see Linux screenshot). I believe the only reason the > FormToolkit is used in the dialog is for expandable composites but I am not even > that is strictly needed so it maybe a good idea to remove it from the API all > together. I incorrectly assumed that the FormToolkit was in there for a reason. I can re-work this one to avoid using the form toolkit. > I have looked for other examples in the Eclipse UI where a bold font is used to > indicate the default but could not find any. I think appending "(default)" is > sufficient to highlight the default option. okay > On first sight I found it difficult to figure out how to disable the extension. > It was not obvious to me that "Plain Text" does this. How about replacing the > first option by an "Enable" checkbox? Can do. Perhaps Mik can provide feedback on this, as 'Plain Text' was his suggestion. To me 'Plain Text' is very intuitive.... how does 'Enable' relate to editor settings? There's no text to indicate what's being enabled or disabled.
> I incorrectly assumed that the FormToolkit was in there for a reason. I can > re-work this one to avoid using the form toolkit. I looked at some code from JDT (bug 253142) and was surprised that they actually use a form toolkit in the dialog as well but set foreground and background color to null. At the moment I am unsure whether it's a good idea to expose it in the API or if the actual toolkit should only be accessible through wrapper methods (e.g. for registering key and focus listeners on the widget). We can discuss this further on bug 253142. > Can do. Perhaps Mik can provide feedback on this, as 'Plain Text' was his > suggestion. > To me 'Plain Text' is very intuitive.... how does 'Enable' relate to editor > settings? There's no text to indicate what's being enabled or disabled. Good point. I was thinking too much from a technical perspective. Plain Text is actually more descriptive, so it makes sense to leave it the way it is.
Created attachment 116898 [details] implementation patch with bits from bug 244650 provides a configuration settings section 'Editor' in the task repository properties dialog also adds a properties dialog for the local repository
Created attachment 116899 [details] mylyn/context/zip
Great patch! I have applied it with minor modifications: Moved TaskEditorExtensionSettingsContribution to editors package and fixed copyright headers. Fixed minor bug that caused TaskEditorExtensionSettingsContribution.createControl() to append default label twice. Note that I have disabled the property page of the local task repository for now. The local task editor does not yet support the task editor extension which should be resolved first.
Thanks, Steffen!
