Bug 235439 - Local Task repository should have a settings page
Summary: Local Task repository should have a settings page
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 256554 (view as bug list)
Depends on: 189312 244653 253115
Blocks:
  Show dependency tree
 
Reported: 2008-06-03 15:08 EDT by David Green CLA
Modified: 2009-05-27 16:04 EDT (History)
4 users (show)

See Also:


Attachments
screenshot (12.31 KB, image/png)
2008-11-02 17:41 EST, Steffen Pingel CLA
no flags Details
mylyn/context/zip (1.57 KB, application/octet-stream)
2009-05-27 16:04 EDT, Shawn Minto CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Green CLA 2008-06-03 15:08:57 EDT
in the 'Task Repositories' view all repositories have a properties dialog where configuration settings can be made.  The 'Local Tasks' repository has no such dialog, which makes it impossible to add configuration settings for the ITaskEditorExtension.
Comment 1 David Green CLA 2008-06-03 15:09:44 EDT
related to bug# 234210
Comment 2 Mik Kersten CLA 2008-06-04 14:32:28 EDT
Steffen: this could be a good task for Owen?
Comment 3 Steffen Pingel CLA 2008-06-04 15:35:12 EDT
Yes, we should consider this once we have made more progress on the editor integration and are ready to integrate it with the local task editor. Before we do this I would like to resolve bug 233378.

We may also need to generalize the extensibility of the settings page similar to the editor to allow parts to be contributed to it rather than bloating the abstract class.
Comment 4 David Green CLA 2008-08-19 23:18:19 EDT
is it still a priority to move the task editor selection into the properties dialog?  If so, I'll work on an extension point for contributing to the repository properties page and enable a properties dialog for the local task repository.
Comment 5 Mik Kersten CLA 2008-09-03 23:45:07 EDT
Yes, it's still a priority since it will make WikiText easier to roll out to Mylyn users by making it optional.  However, note that we don't use any tabbed properties in the Task Repository properties dialog.  Could we get it all into an "Editor" foldable section?
Comment 6 David Green CLA 2008-09-04 00:33:57 EDT
(In reply to comment #5)
> Yes, it's still a priority since it will make WikiText easier to roll out to
> Mylyn users by making it optional.

I've opened a new bug 246171 to discuss this issue (making it optional)

> However, note that we don't use any tabbed
> properties in the Task Repository properties dialog.  Could we get it all into
> an "Editor" foldable section?

Take a look at the patch on bug 244653, which includes an extension point for contributing to the properties dialog and also makes the local task repository have a properties dialog.   You'll be pleased to see that it doesn't use tabs, but fits in with the existing look and feel by contributing foldable sections which by default are collapsed.
Comment 7 Steffen Pingel CLA 2008-11-02 17:41:22 EST
Created attachment 116754 [details]
screenshot

If I toggle the expandable composite the client composite does not appear unless I force a relayout by resizing the dialog
Comment 8 David Green CLA 2008-11-03 16:14:47 EST
(In reply to comment #7)
> If I toggle the expandable composite the client composite does not appear unless
> I force a relayout by resizing the dialog

Which patch did you use to create this screenshot?  My latest patch ensured that the composite was expanded by default for the local tasks repository, since they're the only settings available.
Comment 9 Steffen Pingel CLA 2008-11-03 17:46:40 EST
Right, I think it is missing a repack() or layout() call in case the user toggled (unexpanded/expanded) the expandable section. I think we should provide a method in AbstractTaskRepositoryPage for creating an expandable composite that register the appropriate listener.
Comment 10 Steffen Pingel CLA 2008-11-04 21:38:00 EST
The implementation is now in cvs head (bug 253115) but the task editor extension needs to be made available in the local editor (bug 211096) before the properties action can be disabled for the local repository.
Comment 11 David Green CLA 2008-11-09 15:13:25 EST
moved to UI component
Comment 12 Steffen Pingel CLA 2008-11-26 12:50:39 EST
*** Bug 256554 has been marked as a duplicate of this bug. ***
Comment 13 Jörg Thönnes CLA 2008-11-27 08:56:21 EST
(In reply to comment #12)
> *** Bug 256554 has been marked as a duplicate of this bug. ***

With regard to the above bug (256554: Allow to configure WikiText markup for the Local tasks / Notes tab)
the Local task could serve as some sort of base class for the other connectors in this way:

The dialog to configure the WikiText markup to be used in the "Planning Notes" could also be provided
in the other connectors to configure the Planning pane. The default for the Notes should be the markup
used by the repository.
Comment 14 Shawn Minto CLA 2009-05-27 16:04:03 EDT
The settings page was already provided.  All that had to be done was to enable to command contribution through plugin.xml.
Comment 15 Shawn Minto CLA 2009-05-27 16:04:09 EDT
Created attachment 137408 [details]
mylyn/context/zip