Community
Participate
Working Groups
Sections on Repository Settings page could be separated in a more logical way. Below are some notes from last meeting on possible changes: 1. "Additional Settings" section should be called "<Repository Name> Specific Settings", since that's what really goes there right now 2. Character Encoding settings should be moved out of "Additional Settings" and into their own section or into a true "Additional Settings" section 3. Proxy and HTTP authentication settings could be grouped together in an "Authentication" section 4. "Status" section could become a checkbox next to the "Server" definition 5. If there is a true "Additional Settings" section, it should be the last section in the list, with custom settings contributed by extensions going above it.
Helen, are you currently working on this bug? While I think it's a good idea to restructure the page I don't see how we can do this without breaking backwards compatibility. Many connectors extend AbstractRepositorySettingPage and expect a specific layout when contributing controls. I would suggest to resolve bug 242445 first and we can consider further enhancements for a future milestone.
Yes, I am working on this bug right now, and have it almost done -- just need to make sure I merge correctly with the previous checkin. It was surprisingly time consuming, since the string field combination controls used in the class mess around with the parent's layout, and i had to work around that (after figuring out it was actually happening). You have a very good point about backward compatibility. I think the main thing I am changing is making the page's main composites in general have 3 columns instead of 2. I suppose it is possible that people would depend on the 2 column layout, although, from a connector implementor's point of view, I imagined that the Additional Settings section is what would be most touched by people adding to the page. You could argue that since there are API changes for 3.1, people would expect layout changes too.
Great! I'll review as soon as you post the patch and test with other connector implementations.
Actually, I wasn't working on this one -- sorry -- I thought this was the other bug (bug 242445). I just uploaded a patch for that one. Honestly, I don't think I will be able to get to this one in the time left. Sorry for my misunderstanding. Should I change the milestone on it?
Yes, let's just remove the milestone for now and revisit once your patch is applied and we have a sense of how the layout changes affect the setting page.
Ok, I changed the milestone to 3.2, since completely removing it wasn't possible (at least through the mylyn ui)
I have set it to "---" which we use as the no milestone milestone :).
Works for me :-)
This was resolved for Mylyn 3.1. We'll open new bugs to track any remaining items.
