Bug 242445 - [api] update layout of repository settings page
Summary: [api] update layout of repository settings page
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.1   Edit
Assignee: Helen Bershadskaya CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on: 244653
Blocks:
  Show dependency tree
 
Reported: 2008-07-29 13:59 EDT by Robert Elves CLA
Modified: 2009-02-20 13:56 EST (History)
3 users (show)

See Also:


Attachments
Updated page layout for more logical control connections (15.79 KB, patch)
2009-01-30 19:43 EST, Helen Bershadskaya CLA
no flags Details | Diff
update repository settings image for bugzilla repository (51.24 KB, image/jpeg)
2009-02-05 02:12 EST, Helen Bershadskaya CLA
no flags Details
updated settings page for a connector with less options enabled (xplanner) (48.25 KB, image/jpeg)
2009-02-05 02:15 EST, Helen Bershadskaya CLA
no flags Details
most settings collapsed -- default view for most connectors (39.66 KB, image/jpeg)
2009-02-05 02:17 EST, Helen Bershadskaya CLA
no flags Details
Patch including last suggestions from ui review (35.59 KB, patch)
2009-02-12 02:44 EST, Helen Bershadskaya CLA
no flags Details | Diff
mylyn/context/zip (53.89 KB, application/octet-stream)
2009-02-12 02:45 EST, Helen Bershadskaya CLA
no flags Details
default view of settings dialog (bugzilla repository) (39.99 KB, image/jpeg)
2009-02-12 02:50 EST, Helen Bershadskaya CLA
no flags Details
view when expanding http and proxy settings sections (56.28 KB, image/jpeg)
2009-02-12 02:51 EST, Helen Bershadskaya CLA
no flags Details
view with no anonymous user checkbox (xplanner) (36.41 KB, image/jpeg)
2009-02-12 02:51 EST, Helen Bershadskaya CLA
no flags Details
alternate icon (588 bytes, image/gif)
2009-02-13 18:24 EST, Mik Kersten CLA
no flags Details
updated patch (55.91 KB, text/plain)
2009-02-16 21:14 EST, Steffen Pingel CLA
no flags Details
Patch for user id editor spanning only 2 columns if no anonymous checkbox (14.28 KB, patch)
2009-02-20 01:54 EST, Helen Bershadskaya CLA
no flags Details | Diff
mylyn/context/zip (22.04 KB, application/octet-stream)
2009-02-20 01:54 EST, Helen Bershadskaya CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Elves CLA 2008-07-29 13:59:10 EDT
As per Mylyn conference call...

User Credentials:
* Move "Anonymous Access" checkbox to right of User Id field and rename to "Anonymous"
* Move "Save Password" check box to right of password text box

Http Authentication:
* Move "Enabled" checkbox to right of User ID
* Move "Save http password" to right of password field and rename to "Save Password"

Proxy:
* Move "enable proxy authentication" to right of host address
* Move "Save Proxy Password" to right of password field and rename to "Save Password"

Validate Button:
* validate settings button moves to right of question mark (bottom left)
* add "validate settings on close" check box under the "create new account" links
Comment 1 Steffen Pingel CLA 2008-09-24 00:02:05 EDT
Helen, it is probably best to wait until the patch on bug 244653 is merged before starting on this to avoid conflicts.
Comment 2 Steffen Pingel CLA 2009-01-29 23:52:19 EST
I think we should consider doing this item form bug 251584 as part of this bug as well:

 ?Status? section could become a checkbox next to the ?Server? definition
Comment 3 Helen Bershadskaya CLA 2009-01-30 19:43:54 EST
Created attachment 124346 [details]
Updated page layout for more logical control connections
Comment 4 Helen Bershadskaya CLA 2009-02-05 02:12:33 EST
Created attachment 124780 [details]
update repository settings image for bugzilla repository
Comment 5 Helen Bershadskaya CLA 2009-02-05 02:15:19 EST
Created attachment 124781 [details]
updated settings page for a connector with less options enabled (xplanner)
Comment 6 Helen Bershadskaya CLA 2009-02-05 02:17:42 EST
Created attachment 124782 [details]
most settings collapsed -- default view for most connectors
Comment 7 Mik Kersten CLA 2009-02-05 13:51:42 EST
Feedback from UI review:
* "Anonymous Access" -> "Anonymous"
* "Disconnect Mode" -> "Disconnected" and moves to the right of the "Label:" field
* "Save Http Password" -> "Save Password"
* "Enabled" (checkbox) -> "Enable Http Authentication", moves back to previous location
* "Enable Proxy Authentication" -> fix capitalization, move back to previous location
* "Save Proxy Password" -> "Save Password"
* For foldable headers bold like the compiler preferences page (preferably via toolkit, but not necessary)
Comment 8 Helen Bershadskaya CLA 2009-02-12 02:44:57 EST
Created attachment 125493 [details]
Patch including last suggestions from ui review
Comment 9 Helen Bershadskaya CLA 2009-02-12 02:45:02 EST
Created attachment 125494 [details]
mylyn/context/zip
Comment 10 Helen Bershadskaya CLA 2009-02-12 02:50:36 EST
Created attachment 125495 [details]
default view of settings dialog (bugzilla repository)
Comment 11 Helen Bershadskaya CLA 2009-02-12 02:51:11 EST
Created attachment 125496 [details]
view when expanding http and proxy settings sections
Comment 12 Helen Bershadskaya CLA 2009-02-12 02:51:52 EST
Created attachment 125497 [details]
view with no anonymous user checkbox (xplanner)
Comment 13 Mik Kersten CLA 2009-02-13 18:24:15 EST
Created attachment 125700 [details]
alternate icon

Helen: Great stuff!

Steffen: Please try this icon for "Validate Settings".
Comment 14 Steffen Pingel CLA 2009-02-16 21:14:51 EST
Created attachment 125846 [details]
updated patch
Comment 15 Steffen Pingel CLA 2009-02-16 21:19:31 EST
Thanks Helen for getting this done Helen! I have applied the patch with a few modifications: After all controls are created the original layout is re-applied to avoid modifications of the column count after constructing field editors. I have updated the icon and simplified the extensibility of AbstractTaskRepositoryPage slightly. Both classes now expect a three column GridLayout.

Marking as API since a new image was added to TasksUiImages and I have extracted creation of Section to AbstractTaskRepositoryPage.createSection().
Comment 16 Steffen Pingel CLA 2009-02-19 13:14:43 EST
Helen, on the call it was suggested to shorten the User ID text field when repositories do not support anonymous access. Could you look into that? 
Comment 17 Helen CLA 2009-02-19 14:57:02 EST
Sure.  Hopefully in the next day or so...
Comment 18 Helen Bershadskaya CLA 2009-02-20 01:54:28 EST
Created attachment 126259 [details]
Patch for user id editor spanning only 2 columns if no anonymous checkbox

last column is left empty, if no anonymous checkbox -- for balance
Comment 19 Helen Bershadskaya CLA 2009-02-20 01:54:34 EST
Created attachment 126260 [details]
mylyn/context/zip
Comment 20 Steffen Pingel CLA 2009-02-20 13:56:42 EST
Thanks Helen. I have applied the patch. I do think it looks cleaner.