Community
Participate
Working Groups
Build ID: I20080617-2000 Steps To Reproduce: GridItem have a number of not garbage collected fields caused by cross references. Please fix dispose method of GridItem. GridItem dispose() line: 287- :::::::::FROM::::::::::: /** * {@inheritDoc} */ public void dispose() { if (!parent.isDisposing()) { parent.removeItem(this); if (parentItem != null) { parentItem.remove(this); } else { parent.removeRootItem(this); } for (int i = children.size() - 1; i >= 0; i--) { ((GridItem)children.get(i)).dispose(); } } super.dispose(); :::::::::TO::::::::::: /** * {@inheritDoc} */ public void dispose() { if (parent != null && !parent.isDisposing()) { parent.removeItem(this); if (parentItem != null) { parentItem.remove(this); parentItem = null; } else { parent.removeRootItem(this); } { for (int i = children.size() - 1; i >= 0; i--) { ((GridItem)children.get(i)).dispose(); } children.clear(); children = null; } { backgrounds.clear(); backgrounds = null; foregrounds.clear(); foregrounds = null; grayeds.clear(); grayeds = null; checks.clear(); checks = null; checkable.clear(); checkable = null; columnSpans.clear(); columnSpans = null; images.clear(); images = null; texts.clear(); texts = null; tooltips.clear(); tooltips = null; } parent = null; } super.dispose(); } More information:
please create a patch against header_footer branch then I'll commit it
still I'd prefer to get a patch from your side
patch against HEAD please
Hi all, New implementation remove all data visualization collections. Please see: https://git.eclipse.org/r/#/c/21322/ https://bugs.eclipse.org/bugs/show_bug.cgi?id=419928 http://mirkopaturzo.wordpress.com/2014/02/06/grid-contribution-improve-performace/ Please see snippets below: http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/tree/examples/org.eclipse.nebula.snippets/src/org/eclipse/nebula/snippets/grid/viewer/GridViewerSnippetWithAdaptedDataVisualizer.java http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/tree/examples/org.eclipse.nebula.snippets/src/org/eclipse/nebula/snippets/grid/viewer/GridViewerSnippetWithColumnRowBigDataVisualizer.java http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/tree/examples/org.eclipse.nebula.snippets/src/org/eclipse/nebula/snippets/grid/viewer/GridViewerSnippetWithRowColumnBigDataVisualizer.java Soon, another snippet with dispose example. Mirko
Improve dispose performance
Test done and bug fixed