Community
Participate
Working Groups
Hi all, in this projects there are some performance improvements and the solution of bug 248386. A little description There is no more collection within the GridItem , this greatly improves the creation and management of data. Everything is based on DataVisualizer . This is a centralized component that is allowed to set and get information such as: what is my fonts? what is my background? what is my text ? I implemented three types of DataVisualizer : 1 ) ColumnRowBigDataVisualizer . This simply saves the data from column / row in Map < Integer , List Of T > 2 ) RowColumnBigDataVisualizer , as above, but save rows / columns 3 ) the real news, the AdaptedDataVisualizer that works as a LabelProvider . Thanks to AdaptedDataVisualizer Shot down the memory usage I fixed some bugs for memory leaks and improve performance of Grid OnPaint method .. A change that I could not give to you is the removal of the IsVisible method and the reimplementation of all the calculations of the first index to be seen, the performance increase greatly. Instead, for "creating incremental GridItem " I do not think that my implementation is stable , however if you are interested , I will try to improve it. For now I do not give to you . Attached tests and changes Thanks for your attention Mirko
Created attachment 236690 [details] Test and patch
Dispose a Grid is top slow.. For improvement see clearlAll AMD disposeOnly method
(In reply to Mirko Paturzo from comment #1) > Created attachment 236690 [details] > Test and patch Thank you Mirko. Is it possible to apply a workspace patch to the bug? It is not possible to find and evaluate your changes otherwise.
Created attachment 236693 [details] Patch start from git repository There are two patch on this 7zip file Mirko
Created attachment 236694 [details] Tests i forgot the examples.. Sorry Thanks so much Mirko
Created attachment 236695 [details] Patch start from git repository
Excuse me.. My first time.. i changed the patch file.. There are 2 projects with jface GridTableViewer.. Sorry for my mistake
Looking forward to see those changes. Due to the bug being on status NEW I assume that this is not already part of the version I can find on http://www.eclipse.org/nebula/downloads.php ?
Mirko can you please put your patch in Gerrit? https://wiki.eclipse.org/Nebula/Contributions#Patches
Mirko please sign the CLA otherwise we cannot accept patches.
Hi all, I have signed the CLA agreement. I have put in Gerrit the patch as suggested. Please contact me again if you have any questions. Mirko (In reply to Wim Jongman from comment #10) > Mirko please sign the CLA otherwise we cannot accept patches.
(In reply to Mirko Paturzo from comment #11) > Hi all, > I have signed the CLA agreement. > I have put in Gerrit the patch as suggested. Mirko I see no change in Gerrit. Can you try again? https://wiki.eclipse.org/Nebula/Contributions#Patches
Hi, Could you try now? (In reply to Wim Jongman from comment #12) > (In reply to Mirko Paturzo from comment #11) > > Hi all, > > I have signed the CLA agreement. > > I have put in Gerrit the patch as suggested. > > Mirko I see no change in Gerrit. Can you try again? > > https://wiki.eclipse.org/Nebula/Contributions#Patches
Gerrit review accepted by Wim Jongman and commit in master. https://git.eclipse.org/r/#/c/21324/
