Community
Participate
Working Groups
Build ID: M20071023-1652 Steps To Reproduce: 1. Find a png image of known size and place it in c:\ 2. Create a new rptdesign and add image report item to it. 3. Set the size of the image report item to the size of the png image and the url to the c:\myimage.png 4. Create a pdf report. print it. 5. Open the png image in a editor(ex Paint on windows) and print it. The image in pdf report is 30% larger than the actual png image. More information: http://www.birt-exchange.com/modules/vbulletin/showthread.php?t=10762
can the designer get the DPI of the design environment and set it in the design file? so the engine can use the DPI to generate the PDF/PS.
we need add a render option about the DPI, it is used to convert the px to pt in PDF. The user should set it same with the screen DPI used to design the image.
Hello submitter - can you please attach a copy of the png file that you used to reproduce this issue?
Created attachment 105517 [details] png file The png file size is (width 470px, height 290px)
ENGINE has add a render option about the DPI. Can VIEWER get the client screen DPI and send it to ENGINE?
(In reply to comment #5) > ENGINE has add a render option about the DPI. > Can VIEWER get the client screen DPI and send it to ENGINE? It should be the designer to set the DPI to the image report item definition, not the viewer. Engine can pick up the DPI from image report item property. Do we need model to add DPI property for image?
(In reply to comment #6) > (In reply to comment #5) > > ENGINE has add a render option about the DPI. > > Can VIEWER get the client screen DPI and send it to ENGINE? > > It should be the designer to set the DPI to the image report item definition, > not the viewer. Engine can pick up the DPI from image report item property. > Do we need model to add DPI property for image? > both the designer and the viewer should set the DPI for ENGINE. The designs defines the DPI used in the design time while the viewer set the DPI uses to render the report. we have following DPIs: DESIGN DPI: the DPI setted by the designer, it can be a integer value or ZERO. VIEW DPI: the DPI setted by the viewer, it can be a integer value or ZERO. IMAGE DPI: the DPI defined in the image itself, it is a property in the image header, it can be a integer value of ZERO. IMAGE ITEM DPI: the DPI defined in the image item, it is defined in the design. It can be a integer value or ZERO or "AUTO". which means use the IMAGE DPI. In design time, the designer should: 1. Define the DPI in the report design, It is used to calculate the physical size in px. 2. When user insert a image, if image have IMAGE DPI setting, the designer should use the IMAGE DPI to calculate the image size and set it on the image item. 3. If the image has no IMAGE DPI the designer should use the DESIGN DPI to calculate the size and set it on the image item. 4. For all images, the user can also set IMAGE ITEM DPI on the item. The IMAGE ITEM DPI setting is used to calculate the image size if the user can't define the size at design time. It is useful for URL image or EXPR image. In render time, the viewer should set a VIEWER DPI in IRenderOption, it is used to convert design time px size to render time size. 1. for images with physical size, use it directly. 2. for size with PX, calculate the size as: SIZE * DESIGN_DPI / VIEW_DPI. 3. For any image without size, get the DPI setting through the following sequence: a. the IMAGE ITEM DPI setting on the image item. b. if the IMAGEITEM DPI is "AUTO", use the IMAGE DPI. c. Use the DESIGN DPI. d. use the VIEW DPI. e. default DPI (72DPI) calculate the image size as: pixels_in_image / DPI. For some output (such as HTML), if it is hard to get the IMAGE DPI, we can totally ignore the step (b).
Currently viewer already passes the dpi setting to engine: http://127.0.0.1:51713/viewer/preview?__report=D%3A%5CWork%5Cruntime-workbench-workspace%5Cbug%5CCrosstab_Script.rptdesign&__format=pdf&__svg=true&__locale=en_US&__masterpage=true&__rtl=false&__cubememsize=10&__resourceFolder=D%3A%5CWork%5Cruntime-workbench-workspace%5Cbug&__dpi=96&-378782250 though the key name is EngineConstants.APPCONTEXT_CHART_RESOLUTION, it's passed to all extended items. but I'm not sure if engine will use this for image item as well. We may add a DPI property on ReportDesignHandle, this value can be used as default if viewer doesn't pass the setting. But one behavior is, if user copy this design to another desktop with different dpi setting, should the preview generate the report with local desktop setting or design setting? And as viewer always read current desktop setting and pass it to engine, seems this property doesn't have much use. Regarding the Image item dpi, I think we should always use the original dpi setting from image. It's obscure to allow user to change the dpi for an image. The only benefit to having a dpi property set by designer that I can think of is for run-time performance optimization. Also designer cannot always get the correct dpi from image item(i.e. dynamic url, image from DB), in this case, engine still need to scan the image data.
Wei's solution is very flexible, but I am afraid requiring all report viewer to set DPI will make engine API too difficult to use. I suggest we make it optional. To summarize what Wei suggest and Zhiqiang's proposed modification 1. for images with physical size, use it directly. 2. for image size propert set in px and a design DPI property is set to a value (not auto) on the image, calculate the size as: SIZE / DESIGN_DPI. 3. for image size propert set in px and a design DPI property is set to AUTO on the image, decide DPI with following sequence: a. Get the DPI from image data's header b. DPI on the report design root handle (need to add a IMage DPI property on report design handle) c. Render task option of Image DPI if it is set (need to add a Image DPI setting on render task option) d. 72DPI. calculate the image size as: px / DPI. With this modification, BIRT bundled sample viewer should NOT need to set DPI. 3(b) and 3(c) is only for those special report design or applications that need to control the DPI of image items when the item itself has not set DPI property, nor the image data contains DPI info. So changes are NOT needed in viewer. There should be changes in engine. model, and designer only.
Need more time to resolve this bug. Suggest moving to next release.
defer to 2.5.0 so we can resolve it with several other DPI issues.
Where is the development roadmap listed? I would also like to see this bug fixed. Thanks
(In reply to comment #12) > Where is the development roadmap listed? > I would also like to see this bug fixed. > Thanks Please check http://wiki.eclipse.org/BIRT_Project_Plan for latest plan.
Assign to Model team for adding: design DPI property on image item, and image DPI property on report design handle.
*** Bug 237426 has been marked as a duplicate of this bug. ***
(In reply to comment #14) > Assign to Model team for adding: > design DPI property on image item, > and image DPI property on report design handle. > Please refer to 260350. Properties have been added.
To be compatible with web browser, the 3.d default DPI is set to 96. Fixed.
First we use the default DPI from image header, and if it hasn't DPI setting, user can specify Image DPI property on report design, if the image hasn't default DPI or DPI on the report design root handle, we set a default 96DPI. Verified in 2.5.0 v20090204-0630 build. Mark as verified.
*** Bug 261220 has been marked as a duplicate of this bug. ***
