Bug 23265 - Provide first class JAR support in Workbench
Summary: Provide first class JAR support in Workbench
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 108278 116753 157402 (view as bug list)
Depends on:
Blocks: 23341
  Show dependency tree
 
Reported: 2002-09-06 09:37 EDT by Stef van Dijk CLA
Modified: 2010-11-09 08:14 EST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stef van Dijk CLA 2002-09-06 09:37:32 EDT
When there are two editors defined for a particular file and that file is inside
a jar, only the Open action is available. Therefore, only one editor (hard to
know which) can be opened and there is no Open With action to allow for the
other editor to be used.
By changing which is the default in the plugin.xml, I have verified that both
editors are valid to be used against a jar entry, so why is Open With not
available on the context menu?
The problem is in OpenEditorActionGroup.addOpenWithMenu() where it checks that
the resource is an instanceof IFile. In this case, the resource is an IStorage.
Comment 1 Dirk Baeumer CLA 2002-09-06 11:27:12 EDT
The problem is that the OpenWith menu also contains external editors which 
don't work on IStorage. So we need a special Open With menu in this case. In 
general I think we need better "first class support" of jars and zip from the 
workbench.
Comment 2 Patrick Mueller CLA 2002-09-09 08:00:40 EDT
Ideally, you might want to be able to edit and save a file from a .zip/.jar 
archive.  WinZip let's you do this, for instance.  However, in general, for 
Java, you probably don't want people opening writable editors against jar 
entries.  It might be nice to allow this as an override or something.

Even if you don't allow 'saving' changed contents of a zip file back to the 
zip, it would be nice to allow any editor, including external ones, to 
basically work.  Again, the WinZip way would be to copy the file to a temp 
location and let you edit from there.  
Comment 3 Stef van Dijk CLA 2002-09-09 08:52:47 EDT
Our editor supports a read-only mode when launched on an IStorage object. 
Apparently the default text editor used by JDT does as well. The problem is 
that I can't have them both available since there's only the single Open action.
Comment 4 Dirk Baeumer CLA 2003-08-27 07:53:57 EDT
Moving platform since first class zip support should be provided by 
core.resources.
Comment 5 John Arthorne CLA 2004-03-25 16:45:33 EST
Refiling...
Comment 6 John Arthorne CLA 2005-01-06 12:25:16 EST
Marking old enhancement requests that we don't intend to fix in the near future
as RESOLVED LATER. This does not mean we will never do them, but it means we
have no specific plans to address them.
Comment 7 Martin Aeschlimann CLA 2006-06-24 03:18:09 EDT
*** Bug 116753 has been marked as a duplicate of this bug. ***
Comment 8 John Arthorne CLA 2006-09-26 15:47:16 EDT
*** Bug 157402 has been marked as a duplicate of this bug. ***
Comment 9 Frederic Fusier CLA 2006-10-26 10:30:37 EDT
*** Bug 108278 has been marked as a duplicate of this bug. ***
Comment 10 John Arthorne CLA 2009-08-18 16:15:19 EDT
[LATER->WONTFIX] The "LATER" bugzilla resolution is being removed so reopening to mark as WONTFIX.
Comment 11 John Arthorne CLA 2009-08-18 16:21:16 EDT
[LATER->WONTFIX] The "LATER" bugzilla resolution is being removed so reopening to mark as WONTFIX.
Comment 12 Aaron Digulla CLA 2009-12-11 07:45:27 EST
I think that the gist of this bug is that it should happen; only the team doesn't have the resources to do them. Can you open it with "patches welcome"?

I mean the whole infrastructure is there: In the JDT, I can open JAR files and browse them. It shouldn't be too hard to extend the VFS support for archives.