Bug 220609 - [ErrorHandling] Ugly error dialog
Summary: [ErrorHandling] Ugly error dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-02-27 12:10 EST by Markus Keller CLA
Modified: 2008-03-28 09:15 EDT (History)
4 users (show)

See Also:


Attachments
Screenshot (17.87 KB, image/png)
2008-02-27 12:10 EST, Markus Keller CLA
no flags Details
Reproduction (32.63 KB, image/jpeg)
2008-02-28 04:03 EST, Krzysztof Daniel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-02-27 12:10:31 EST
Created attachment 90892 [details]
Screenshot

I20080226-1155

I guess this is the status dialog that was mentioned on the mailing list. Could the Platform/UI team please ensure that their stuff is at least sanity checked before it goes into a build?
Comment 1 Krzysztof Daniel CLA 2008-02-27 14:24:19 EST
New status dialog is being improved (see bug 220523).

I would like to have here reproduction scenario (dialog does not usually look like on Markus' screenshot).

And 'sanity' is a little bit offending...

Please assign this bug to me
Comment 2 Markus Keller CLA 2008-02-27 14:39:03 EST
> I would like to have here reproduction scenario (dialog does not usually look
> like on Markus' screenshot).

I got the dialog when I tried to do 'Replace With > Latest from HEAD' on a file
that was locked by another application (in my case, it was a buggy Firefox, but
MS Word also a known locker). Then I resized it a bit.

> And 'sanity' is a little bit offending...

I didn't say anyone is insane. "Sanity check" is a well-known English term that
means "a quick check to see that the stuff works fine". I would expect that an
Eclipse contributor/committer quickly checks the basic functionality before he
releases something that will jump into many users' eyes.
Comment 3 Krzysztof Daniel CLA 2008-02-28 04:03:49 EST
Created attachment 90978 [details]
Reproduction

Markus,
Here is the the error dialog that appeared to me when I tried to reproduce reported one.
I think you have resized that dialog before capturing it - so basically I see here two issues
* do not allow user to resize the dialog (at least until bug 210748 will be fixed)
* work on maximal width of the error dialog (wrapping message).

Does this address your concerns?
Comment 4 Markus Keller CLA 2008-02-28 04:19:19 EST
> * do not allow user to resize the dialog (at least until bug 210748 will be
> fixed)

No, all dialogs with variable contents must be resizable. Better leave it as is until bug 210748 is fixed.

> * work on maximal width of the error dialog (wrapping message).

Yes, the upper message should have a widthHint. I have not looked at the implementation, but if you have a GridLayout, then the upper message would need a
    new GridData(SWT.FILL, SWT.FILL, true, false),
and the details pane would be
    new GridData(SWT.FILL, SWT.FILL, true, true),
Comment 5 Szymon Brandys CLA 2008-02-28 05:14:35 EST
Thanks for the valuable feedback Markus. 

Some issues can occur due to the release of the dialog.  Showing the dialog to people and getting such comments will help us to make the dialog (and all related stuff) better. 

I didn't notice that issue and I wouldn't have noticed that, if the dialog had not been released.
Comment 6 Krzysztof Daniel CLA 2008-03-06 07:25:24 EST
Patch for bug 133495 solves this issue, too.
Marking as fixed.
Comment 7 Krzysztof Daniel CLA 2008-03-28 08:37:42 EDT
28-03-2008 verified using testtool
Comment 8 Markus Keller CLA 2008-03-28 09:15:08 EDT
(In reply to comment #6)
> Patch for bug 133495 solves this issue, too.

Not really, that bug only added wrapping. But you can use bug 223056 for the rest.