Bug 223056 - [StatusHandling] Status dialog does not resize nicely
Summary: [StatusHandling] Status dialog does not resize nicely
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 210748 228540 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-18 05:24 EDT by Markus Keller CLA
Modified: 2008-05-06 06:53 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot (18.04 KB, image/png)
2008-03-18 05:24 EDT, Markus Keller CLA 		no flags Details
Fix (changes for testtool included) (20.41 KB, patch)
2008-04-20 07:04 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
Improved fix (20.65 KB, patch)
2008-04-20 07:32 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
Performed tests (867.13 KB, application/x-zip-compressed)
2008-04-20 07:36 EDT, Krzysztof Daniel CLA 		no flags Details
testtool update (4.63 KB, patch)
2008-04-21 06:47 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
Fix (14.44 KB, patch)
2008-04-21 08:16 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
Updated fix (14.58 KB, patch)
2008-04-22 09:12 EDT, Szymon Brandys CLA 		no flags Details | Diff
Updated fix 2 (14.52 KB, patch)
2008-04-22 09:51 EDT, Szymon Brandys CLA 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-03-18 05:24:52 EDT 
Created attachment 92778 [details]
Screenshot

I20080314-1059

See screenshot.
Comment 1 Krzysztof Daniel CLA 2008-03-18 10:30:16 EDT 
Markus, 

Could you please assign this bug to me?

I have noticed you have put there red arrows - do you want me to make details area resizeable? Am I reading them correctly?
Comment 2 Markus Keller CLA 2008-03-18 11:02:14 EDT 
> I have noticed you have put there red arrows - do you want me to make details
> area resizeable? Am I reading them correctly? 

Yes, the middle message label ("Errors have occurred [..]") should stay at the top (where it was initially) when the dialog is made larger.

When the details area is shown, its contents (with white background) should fill the available vertical space (because the contents may be large).

When the details area is collapsed, the middle label must still be top-aligned (not vertically centered as it is today). It would be nice if the OK and Details buttons could be aligned in the bottom right corner of the dialog in this case (with the middle label filling the remaining vertical space).
Comment 3 Markus Keller CLA 2008-03-26 09:47:50 EDT 
Please also set the dialog font to all widgets and test that initial sizing and resizing are OK with a non-default dialog font.
Comment 4 Markus Keller CLA 2008-03-28 09:09:50 EDT 
*** Bug 210748 has been marked as a duplicate of this bug. ***
Comment 5 Krzysztof Daniel CLA 2008-04-20 07:04:18 EDT 
Created attachment 96732 [details]
Fix (changes for testtool included)
Comment 6 Krzysztof Daniel CLA 2008-04-20 07:32:24 EDT 
Created attachment 96733 [details]
Improved fix
Comment 7 Krzysztof Daniel CLA 2008-04-20 07:36:04 EDT 
Created attachment 96734 [details]
Performed tests
Comment 8 Krzysztof Daniel CLA 2008-04-21 06:47:12 EDT 
Created attachment 96819 [details]
testtool update
Comment 9 Krzysztof Daniel CLA 2008-04-21 08:16:29 EDT 
Created attachment 96829 [details]
Fix

Szymon pointed that margin before buttons and the right edge of the dialog are invalid. Fixed.
Comment 10 Szymon Brandys CLA 2008-04-22 07:31:45 EDT 
I agree that the default details area should use default dialog fonts. However I'm not sure if it should be forced for custom details and support view. If one wants to use non-default dialog fonts, we should let him do it.
Comment 11 Szymon Brandys CLA 2008-04-22 09:12:02 EDT 
Created attachment 97008 [details]
Updated fix

Krzysztof, please take a look.
Comment 12 Szymon Brandys CLA 2008-04-22 09:51:06 EDT 
Created attachment 97018 [details]
Updated fix 2
Comment 13 Szymon Brandys CLA 2008-04-22 10:17:27 EDT 
"Updated fix 2" released to HEAD.
Comment 14 Krzysztof Daniel CLA 2008-04-22 10:54:00 EDT 
marking as fixed.
Comment 15 Markus Keller CLA 2008-04-23 13:52:56 EDT 
Looks good in HEAD, except for one little glitch: The margin below the buttons
should be the same size as the margin to the right of the buttons.

Currently, the buttons look a bit "glued" to the lower border of the dialog.
Comment 16 Szymon Brandys CLA 2008-04-24 04:16:32 EDT 
*** Bug 228540 has been marked as a duplicate of this bug. ***
Comment 17 Krzysztof Daniel CLA 2008-04-30 10:01:05 EDT 
Verified in I20080430-0100.

Markus, will you open bug against glued buttons?
Comment 18 Markus Keller CLA 2008-05-06 06:53:51 EDT 
> Markus, will you open bug against glued buttons?
bug 230365