Bug 21977 - [resources] Use preferences for workspace settings
Summary: [resources] Use preferences for workspace settings
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 2.0   Edit
Hardware: Other other
: P2 normal (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Rafael Chaves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 17897 (view as bug list)
Depends on:
Blocks: 19494 27570
  Show dependency tree
 
Reported: 2002-07-26 15:48 EDT by Nick Edgar CLA
Modified: 2003-01-10 12:28 EST (History)
2 users (show)

See Also:

Attachments
patches to core.resources and core.tests.resources (6.88 KB, patch)
2002-11-28 15:32 EST, Rafael Chaves CLA 		no flags Details | Diff
Moves internal constants for properties names to API (3.46 KB, patch)
2002-12-04 14:24 EST, Rafael Chaves CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-07-26 15:48:28 EDT 
R2.0

As described in bug 19494, not all settings in the workbench preference pages 
can be exported.  Some of these are core settings which are not implemented 
using preferences.

Now that the preference mechanism exists at core level, it would be good if 
settings like the following used this mechanism:

- autobuild
- local history settings
- build order
Comment 1 Rafael Chaves CLA 2002-11-28 15:32:49 EST 
Created attachment 2570 [details]
patches to core.resources and core.tests.resources

Please verify and release if it is ok.
Comment 2 DJ Houghton CLA 2002-12-03 10:22:25 EST 
See also bug 27570.
We may have to create new API to better facilitate setting default values.
Holding off on releasing this new code until this other bug is resolved.
Comment 3 DJ Houghton CLA 2002-12-03 13:24:49 EST 
Released into HEAD.
Comment 4 Tod Creasey CLA 2002-12-04 13:09:13 EST 
The WorkspacePreferences class is internal and all of the settings constants 
are defined there. We will need to be able to see this constants for our 
property listeners (for auto build specifically).
Comment 5 Tod Creasey CLA 2002-12-04 13:14:39 EST 
Once we have access to the constants from Core we will also have to start 
listening to the build order preference and generating an auto build from that.

I would suggest splitting WorkbenchPreferenceListener up and adding a 
CorePreferenceListener that generates global build actions for auto build and 
build order.
Comment 6 Rafael Chaves CLA 2002-12-04 14:24:23 EST 
Created attachment 2655 [details]
Moves internal constants for properties names to API

Moved constants from WorkspacePreferences to ResourcesPlugin. Just added basic
comments for each constant for now. I will open another PR for making more
explicit how workspace description objects and core preferences are related.

A test class was affected. The patch fixes tests too.

Please review and release.
Comment 7 DJ Houghton CLA 2002-12-04 14:39:52 EST 
Fixed and released into HEAD.
Comment 8 DJ Houghton CLA 2002-12-04 14:40:39 EST 
Closing
Comment 9 Nick Edgar CLA 2003-01-10 12:28:26 EST 
*** Bug 17897 has been marked as a duplicate of this bug. ***