Community
Participate
Working Groups
- Switch to workweek mode. - Type something in the find box in task list. The filtered results come in some undetermined order (at least I was not able to find a criteria, and didn't look at the code). I'll post a screenshot.
Created attachment 88645 [details] Screenshot
I'll give an award if you guess what is the sorting order for the above screenshot. It certain is NOT: - Priority. - Bug ID. - Summary. The only thing I was able to recognize is that completed tasks are group after non-completed.
Rob: please review.
*** Bug 217531 has been marked as a duplicate of this bug. ***
Updated title as per bug 217530. Rob: note that the order needs to be preserved both for Focused and Unfocused mode (i.e. the sorter should not change).
Need to defer: http://wiki.eclipse.org/index.php/Mylyn/3.0_Plan#Deferred_Items
Frank, since you're investigating other search related bugs I'm reassigning this to you. Just pass back if out of scope.
(In reply to comment #7) > Frank, since you're investigating other search related bugs I'm reassigning this > to you. Just pass back if out of scope. OK, what I found until now is that TaskListInterestSorter.compare should be changed in the same way like TaskListTableSorter.compare (bug#231336) I wait with a pach until the patch for bug#231336 is reviewed.
Created attachment 116105 [details] mylyn/context/zip
I'll move this for 3.2 for now. There are some fixes and refactorings I want to take a look at before we make further changes to the sorting implementation (bug 261998).
It seems that TaskListInterestSorter sorts in the following order: completion state, due date, scheduled date, priority, summary. Since this is essentially a special mode of TaskListSorter I am in favor of replacing TaskListInterestSorter by TaskListSorter after bug 212967 has been resolved. Frank, what are your thought on this?
(In reply to comment #11) > It seems that TaskListInterestSorter sorts in the following order: completion > state, due date, scheduled date, priority, summary. Since this is essentially a > special mode of TaskListSorter I am in favor of replacing > TaskListInterestSorter by TaskListSorter after bug 212967 has been resolved. > Frank, what are your thought on this? > Steffen, yes this looks good to me.
Great, then let's consider this for the next release and complete the pending changes first.
*** Bug 192488 has been marked as a duplicate of this bug. ***
Created attachment 145343 [details] patch please review
Created attachment 145344 [details] mylyn/context/zip
Thanks Frank. I am not sure that that patch addresses the problem. We still want a special sorting order when the task list is focused. I would like to reopen the discussion for the next release. One of the problems with the current search mode is that it displays duplicates when queries in the task list overlap. I find that that impacts the value of filtering significantly and I would like to brainstorm if we can make other improvements along with resolving this bug.
Let's take this off the milestone for now since we are overloaded already.
