Community
Participate
Working Groups
Currently all Archive categories are placed at the end of the task list. In result, active category can be far apart from the actual query node. I suggest, to change default sorting order and use the following rules: -- All local categories should be at the top of the Taks List view -- The rest of the task list should be sorted using the following order: -- repository (same order as in Repositories view) -- query nodes sorted alphabetically by query name -- Archive category for this repository should be placed at the end of the list For example: - My Tasks - Uncategorized - Eclipse/aj [Eclipse.org] - Eclipse/Mylyn [Eclipse.org] - Archive [Eclipse.org] - m2eclipse [Codehaus] - Archive [Codehaus] - Subclipse [Subclipse] - Archive [Subclipse] This way it should be easier to see if query hits are dropped from queries and moved into the Archive
Frank, this is related to your work on bug 231336. To resolve this bug I would suggest to add an additional combo selection for sorting of root nodes that allows choosing between alphabetical sorting and by repository sorting. TaskRepositoriesSorter contains the implementation that is used by the repository selection wizard page and if possible the code should be extracted and reused.
(In reply to comment #1) > Frank, this is related to your work on bug 231336. To resolve this bug I would > suggest to add an additional combo selection for sorting of root nodes that > allows choosing between alphabetical sorting and by repository sorting. > TaskRepositoriesSorter contains the implementation that is used by the > repository selection wizard page and if possible the code should be extracted > and reused. > Steffen, I think that we have three ways for sort here: 1) see bug #231336 this is sorting first by types and then alphabetical sorting of the names 2) alphabetical sorting of the names and for same names then by types 3) repository sorting and then by types (see description) with the following type: - Uncategorized [Inbox] - Unsubmitted [Drafts] - Categories - Queries - TaskGroup - Unmatched [Archive] What do you think?
That sounds good. Here are examples to make sure we mean the same thing: 1) Grouped by Categories and Queries Uncategorized Unsubmitted [Eclipse] Unsubmitted [Other] Category An Eclipse Query Other Query Unmatched [Eclipse] Unmatched [Other] 2) No grouping Uncategorized Unsubmitted [Eclipse] Unsubmitted [Other] An Eclipse Query Category Other Query Unmatched [Eclipse] Unmatched [Other] 3) Grouped by Categories and Repositories Uncategorized Category An Eclipse Query Unsubmitted [Eclipse] Unmatched [Eclipse] Other Query Unsubmitted [Other] Unmatched [Other]
Created attachment 127099 [details] patch New Task Presentation are defined to support this. If you dont like the names feel free to change them.
Created attachment 127100 [details] mylyn/context/zip
Created attachment 129524 [details] updated patch for 3.2 this is the updated patch
Created attachment 129525 [details] mylyn/context/zip
Would it be possible to add this as an option to the Sort dialog? I think adding additional presentations adds more complexity and this feature seems to be closely related to sorting.
Created attachment 134695 [details] patch no presentation Combo added in sortdialog (In reply to comment #8) > Would it be possible to add this as an option to the Sort dialog? I think adding > additional presentations adds more complexity and this feature seems to be > closely related to sorting. Yes here is an posible implementation. Sorry the cleanup of the not used presentations is not done.
Created attachment 134696 [details] mylyn/context/zip
Created attachment 134832 [details] updated patch cleand up version of attachment 134695 [details]
Created attachment 134833 [details] mylyn/context/zip
Created attachment 134916 [details] next iteration
I generalized the implementation slightly to avoid some code duplication. Frank, can you take a look and let me know if that makes sense? I noticed that the setting does not get persisted at the moment. Could you add that to TaskListView using GroupBy.name() and GroupBy.valueOf()?
Created attachment 135034 [details] next patch version next iteration was veryfied and the change from comment#14 are included.
Created attachment 135035 [details] mylyn/context/zip
Good stuff. Steffen and I did a UI review and came up with the following simple changes, which Steffen may be able to implement. It would be nice if the "Theny by" didn't enable themselves until the thing above them had a selection pre.. -- Queries and Categories ---- | Group by: [ ] | ------------------------------ -- Tasks --------------------- | Sort by: [ ] (x) ... | | Then by: [ ] (x) ... | | Then by: [ ] (x) ... | ------------------------------
Created attachment 136130 [details] patch with new UI layout from comment 17 is now supported.
Created attachment 136131 [details] mylyn/context/zip
Created attachment 136261 [details] screenshot for UI review
The patch looks really good. I like the refactoring that you made. The code reuse is much better now. Can you add a simple test case that makes sure the preference migration works? One oddity I noticed is that Ascending/Descending would sometimes change if I selected a sort key in the sort dialog that had already been selected in another combo box. Also the enablement for Ascending/Descending doesn't seem to work if I select a sort key in the last combo box. Can you check that?
Created attachment 136585 [details] updated UI patch (In reply to comment #21) > The patch looks really good. I like the refactoring that you made. The code > reuse is much better now. Can you add a simple test case that makes sure the > preference migration works? > > One oddity I noticed is that Ascending/Descending would sometimes change if I > selected a sort key in the sort dialog that had already been selected in another > combo box. This was not a Bug, it was a Feature which is commented out now. > Also the enablement for Ascending/Descending doesn't seem to work if > I select a sort key in the last combo box. Can you check that? All other is done.
Created attachment 136586 [details] mylyn/context/zip
Thanks for making the changes. This is looking great! I'll do a quick review tomorrow and then apply the patch.
Created attachment 136747 [details] updated patch
I have committed my last patch with a few additional modifications. Frank, I added groups to the UI, renamed a few classes and kept the migration code in TaskListView since that is where the memento was originally handled. Thanks for your hard work and this great patch!
