Bug 213985 - problem with j2ee performance tests
Summary: problem with j2ee performance tests
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Carl Anderson CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on: 208809 209891
Blocks:
  Show dependency tree
 
Reported: 2007-12-28 10:20 EST by Kaloyan Raev CLA
Modified: 2008-08-04 09:32 EDT (History)
1 user (show)

See Also:


Attachments
Update tests to have valid test case names (2.28 KB, patch)
2008-02-13 17:13 EST, Carl Anderson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2007-12-28 10:20:43 EST
This problem was introduced with the changes made in bug 190496. 

After a massive refactoring in the j2ee junit tests, a related performance test has not been updated as necessary: AllCorePerformanceTests in o.e.j.j2ee.core.tests.performance. There, the last five references to junit tests are calls to non-existing test methods:

    EJBProjectCreationOperationTest("testDefaults")
    AppClientProjectCreationOperationTest("testDefaults")
    JCAProjectCreationOperationTest("testDefaults")
    WebProjectCreationOperationTest("testDefaults")
    EJBImportOperationTest("testEJB21Import")

This causes these performance test calls to fail with the quite inadequate failure message: 

    illegal data set: contains neither AVERAGE nor AFTER values.
Comment 1 Kaloyan Raev CLA 2007-12-28 10:26:08 EST
The error thrown by the JUnit framework looks like:

    junit.framework.AssertionFailedError: Method "testEJB21Import" not found

This need to be fixed for both 2.0.2 and 3.0 streams. 
Comment 2 Carl Anderson CLA 2008-01-11 10:53:24 EST
Before he left IBM, Ian got all of this working for WTP 3.0.  He did not get it working for the 2.0.x stream.
Comment 3 Carl Anderson CLA 2008-02-13 17:13:19 EST
Created attachment 89689 [details]
Update tests to have valid test case names
Comment 4 Carl Anderson CLA 2008-02-14 14:59:27 EST
I committed this change to HEAD on 2/13 (but forgot to mark it as such).
Please verify that this now works.
Comment 5 Kaloyan Raev CLA 2008-08-04 09:32:33 EDT
As far as I remember this was resolved.