Community
Participate
Working Groups
The test HeaderParserTests.testSpeed() tests the parse time deviation. We need to remove this test, or relax the assert test, because under heavy server load, this test can fail.
I'd recommend it be removed. I fear it'd have to be loosened so much that it wouldn't mean much. Remember that the build machine is used by hundreds of other processes, so it wouldn't be unusual to get "swapped out" for unpredictably long periods at unpredictable times. If/when we get the performance tests running again, it could go in there, because one condition of running the performance test is having a dedicated machine, so it's always it a known state ... well, a little more predictable at least.
This test needs to be pulled from both 2.0.2 and 3.0 and moved to the performance bucket.
Created attachment 83006 [details] path to remove test from 3.0 This patch removes the test from HeaderPareserTests for the 3.0 stream. Another patch to follow to add the test back in in the performance bucket.
Created attachment 83009 [details] patch to remove test from 3.0 Sorry, forgot to organize the imports on HeaderParserTests before creating patch.
Created attachment 83010 [details] patch to add test back to performance bucket This patch adds the test back in the performance bucket. Need to wait for Bug 208809 to be committed before test can be hooked up to performance test suite.
Comment on attachment 83009 [details] patch to remove test from 3.0 I committed this patch (since the test has recently begun failing on 3.0)
Committed patch to add the test to the performance bucket to HEAD
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.
