Bug 208447 - Editor save read only files without any warning.
Summary: Editor save read only files without any warning.
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2007-11-01 11:58 EDT by Andre Dubrovsky CLA
Modified: 2019-09-06 16:05 EDT (History)
2 users (show)

See Also:


Attachments
CVS settings (86.68 KB, image/jpeg)
2007-11-06 17:45 EST, Andre Dubrovsky CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Dubrovsky CLA 2007-11-01 11:58:22 EDT
Build ID: I20070621-1340

Steps To Reproduce:
1.Mark Resource as read only.
2.Open Editor with doble click on resource.
3.Change content and save.
4.File is saved and not read only more.

More information:
Comment 1 Tod Creasey CLA 2007-11-01 16:13:35 EDT
Which editor?
Comment 2 Andre Dubrovsky CLA 2007-11-01 16:59:14 EDT
We have tested with JavaEditor and PythDev.
Comment 3 Kevin McGuire CLA 2007-11-02 10:29:58 EDT
Tested in 1101 and works as expected, you are prompted for a read only file.  This is unlikely to have changed since 0621.

However, Team repository providers can override this behaviour.  Which are you using?  Please report this bug to them.
Comment 4 Andre Dubrovsky CLA 2007-11-02 14:37:02 EDT
We use CVS. 
Comment 5 Szymon Brandys CLA 2007-11-06 04:53:08 EST
It works as expected in 3.3.
Comment 6 Andre Dubrovsky CLA 2007-11-06 15:21:27 EST
I put generated sources in .cvsignore and mark it as "read only".
I think, it is not work as expected, if I can change protected sources that not under CVS control without any warnings!
Comment 7 Kevin McGuire CLA 2007-11-06 15:55:45 EST
(In reply to comment #6)
> I put generated sources in .cvsignore and mark it as "read only".
> I think, it is not work as expected, if I can change protected sources that not
> under CVS control without any warnings!

What it meant was, "working as expected given the information we have at hand". 

So to be clear, the case then is (?):

1. create a file foo.txt
2. add it to .cvsignore
3. set foo.txt to read-only
4. open editor...
5. change content...
6. save...

Comment 8 Andre Dubrovsky CLA 2007-11-06 17:43:31 EST
Yes, a bit sophisticated is a lot of .java files in src directory. The src directory is added to .cvsignore.
Comment 9 Andre Dubrovsky CLA 2007-11-06 17:45:09 EST
Created attachment 82277 [details]
CVS settings

How can I change behavior for read only files under CVS control, if the settings are disabled?
Comment 10 Andre Dubrovsky CLA 2007-11-06 17:54:08 EST
Or, if I misunderstood this feature:
How can I change CVS settings so, that the user become always a warning if he trying to change or to override readonly files (even if this files stay under CVS-control)?
Comment 11 Tomasz Zarna CLA 2007-12-07 12:39:55 EST
As mentioned by Kevin in comment 3, overriding the read-only bit by repository providers is an expected behavior -- see bug 67122 and bug 34793. Currently, we don't have the manpower to address it, but if you have strong feelings about this issue you can provide us a patch.
Comment 12 Andre Dubrovsky CLA 2007-12-07 15:41:09 EST
Ok, overriding the read-only bit by repository
providers is an expected behavior.
But if this file is not under CVS control (entered in .cvsignore), this behavior is wrong.
Unfortunately I havn't path for this issue.
Comment 13 Eclipse Webmaster CLA 2019-09-06 16:05:53 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.