Bug 195514 - support spell checking in description, comment and summary field
Summary: support spell checking in description, comment and summary field
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: 3.0   Edit
Assignee: Raphael Ackermann CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 155278 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-07-05 07:37 EDT by Max Berger CLA
Modified: 2007-08-20 17:02 EDT (History)
2 users (show)

See Also:


Attachments
spell checking support for summary line (9.43 KB, patch)
2007-07-31 06:55 EDT, Raphael Ackermann CLA
no flags Details | Diff
mylyn/context/zip (12.10 KB, application/octet-stream)
2007-07-31 06:55 EDT, Raphael Ackermann CLA
no flags Details
Added TextViewer support to the summary field in both the task editor and the newTask editor (14.01 KB, patch)
2007-08-12 09:06 EDT, Raphael Ackermann CLA
no flags Details | Diff
mylyn/context/zip (21.82 KB, application/octet-stream)
2007-08-12 09:06 EDT, Raphael Ackermann CLA
no flags Details
fix for summary size (2.19 KB, patch)
2007-08-19 13:37 EDT, Eugene Kuleshov CLA
no flags Details | Diff
mylyn/context/zip (23.40 KB, application/octet-stream)
2007-08-19 13:38 EDT, Eugene Kuleshov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Max Berger CLA 2007-07-05 07:37:52 EDT
When entering a new bug (such as this one), spelling mistakes are automatically underlined in description and comments, which is nice.  However, this not the case for the summary line, which goes unchecked.

Further, there is currently no way to invoke the auto-correct feature to have eclipse give me a spelling suggestion. I tried Apple-1 (Mac OS X) and Ctrl-1 (Linux), which works fine in the Java editor, but does nothing in the bug editor.
Comment 1 Mik Kersten CLA 2007-07-06 21:54:05 EDT
Yes, I would like to see this too.  Need to mark as helpwanted for now but this is something that we really should add in the 3.0 cycle.
Comment 2 Eugene Kuleshov CLA 2007-07-14 21:20:23 EDT
dupe of 155280
Comment 3 Mik Kersten CLA 2007-07-17 21:45:16 EDT
Updated description to reflect separation with bug 155280.
Comment 4 Eugene Kuleshov CLA 2007-07-17 22:08:03 EDT
BTW, there is no spell checking in attachment dialog and in context attachment dialog too.
Comment 5 Raphael Ackermann CLA 2007-07-31 06:55:48 EDT
Created attachment 75019 [details]
spell checking support for summary line

I had a first go at this bug, using the addTextEditor() method of TaskFormPage, similar to the DescriptionLayout and CommentLayout methods. 

spell checking work, but behavious is different when using pressing the tab key on the keyboard, as it doesn't jump to the next section anymore but inserts a tab. Same behaviour as in the description and comment fields. 

didn't do the attachment dialog or context attachment dialog. 

I also noticed that for local tasks, spell checking doesn't work yet. Probably uses a different summary field.
Comment 6 Raphael Ackermann CLA 2007-07-31 06:55:50 EDT
Created attachment 75020 [details]
mylyn/context/zip
Comment 7 Robert Elves CLA 2007-07-31 15:40:02 EDT
Great first crack at this Raphael - reassigning to you. We should avoid changing api with this patch so could you simply change the implementation of AbstractRepositoryTaskEditor.addSummaryText() to do the right thing? Regarding use of tab, perhaps we could trap that key with a listener and move to the next composite? 
Comment 8 Robert Elves CLA 2007-08-09 18:33:52 EDT
*** Bug 155278 has been marked as a duplicate of this bug. ***
Comment 9 Robert Elves CLA 2007-08-09 18:38:22 EDT
Raphael, should we expect a revised patch for this? Now that we have spelling recommendations (bug#155280) this would really help complete the story.
Comment 10 Raphael Ackermann CLA 2007-08-10 02:23:08 EDT
I haven't had time this week to work on it. but I've got a revised patch almost ready to submit. Will do so tonight or over the weekend.
Comment 11 Raphael Ackermann CLA 2007-08-12 09:06:41 EDT
Created attachment 75922 [details]
Added TextViewer support to the summary field in both the task editor and the newTask editor

Added TextViewer support which enables spell checking. 

Had to add a TabKeyListener to select the next control when the tab key is pressed, instead of adding a tab in the text.
Comment 12 Raphael Ackermann CLA 2007-08-12 09:06:44 EDT
Created attachment 75923 [details]
mylyn/context/zip
Comment 13 Robert Elves CLA 2007-08-14 02:46:52 EDT
Great, I'll look at this first thing tomorrow!
Comment 14 Robert Elves CLA 2007-08-14 12:16:09 EDT
Excellent Raphael. Patch applied, ip log updated. Only some minor changes to names and added back support for setting background when summary has changed. One minor nit, rather than hard code the summary height we will need to make this based on the font height.
Comment 15 Eugene Kuleshov CLA 2007-08-19 13:37:56 EDT
Created attachment 76388 [details]
fix for summary size

used SWT.SINGLE for summary widget and also added small indentation, so text in summary and description fields is don't stick to the left border.
Comment 16 Eugene Kuleshov CLA 2007-08-19 13:38:00 EDT
Created attachment 76389 [details]
mylyn/context/zip
Comment 17 Robert Elves CLA 2007-08-20 17:02:27 EDT
That's great Eugene. Patch applied. Marking resolved.