Community
Participate
Working Groups
Eugene suggested that spelling recommendations be made available via content assist. Another idea would be to populate the context menu with the recommendations. The first hurdle will be actually getting the recommendations form the spelling engine.
I think it would be more Eclipse way to have Ctrl-1 or Ctrl-Space kind of content assist. Framework is actually bound to 3.2 API. You may want to look at http://philipptiedt.blogspot.com/2006/06/decorated-fields-in-eclipse.html Thunderbird is using popup menu for proposals and I still can't get used to it...
By the way. It should be possible to use context of the current task to create code complation proposals. I think we talked about this at some point...
*** Bug 196555 has been marked as a duplicate of this bug. ***
*** Bug 196980 has been marked as a duplicate of this bug. ***
Created attachment 75179 [details] spellchecking quickfix for comment editor and other editors created trough addTextViewer()
Created attachment 75180 [details] mylyn/context/zip
This patch is using Eclipse 3.3 API and I had to do some cleanup to make it work.
Ouch. It seems like I posted it too quick. This patch break hyperlinks for the stack trace elements
Created attachment 75183 [details] spellchecking quickfix (take 2) This patch handle stacktrace hyperlinks properly. Apparently I was operoptimistic about hyperlink detectors and we'll need to fix bug 179856 to make it nice. I actually have it fixed here and will submit patch to bug 179856 once this one is resolved.
Nicely done! Patch applied and verified.
Thanks Rob. Anything else left here or we can resolve it?
Nope I think we're good here, marking resolved...
I'm not currently a Mylyn user, so I apologize if these are silly questions; bug I stumbled over Eugene's blog and I'd like to get spellcheck fixes for JDT: * Will this patch also make spellcheck corrections available in the JDT editor (for Javadoc comments)? * What download / version / milestone do I need to grab to get the fix into my Eclipse 3.3 installation (Mylyn 3.0M1 or what)? What does the target milestone 3.0 mean? * Why is this bug associated with Component Mylyn : Bugzilla? Thanks!
Martin, this bug probably should have been using UI component, since it is related to all Mylyn's task editors. Anyways, it is fixed and you can update Mylyn from the dev update site (its version is between Mylyn 2.0 and 2.1). Eclipse provides spell checking for all text editors (including JDT's ones) since version 3.2. Version 3.3 includes a dictionary, so you don't have to configure your own one. Though it need to be enabled in Window / Preferences / General / Editors / Text Editors / Spelling and spelling annotations in Window / Preferences / General / Editors / Text Editors / Annotations. As far as I know spell checking for the javadocs is enabled automatically once global spell checking is enabled (and when you have dictionaly).
Thanks Eugene. I've been using the JDT spell checking for a while, and I've come up with a nice user_dict.txt in the meanwhile. But I'm editing this with Emacs outside Eclipse. So what I'd really like is the correction quickfix and the "add to dictionary" quickfix in JDT. Will I get this when I get Mylyn v 2.0.x from the dev update site?
Martin, you don't need Mylyn to be able to have spell checking in Java editor. It is supported by JDT out of the box. So, my patch don't have anything to do with that.
Foo! You're right, Ctrl+1 does the spellcheck quickfix for JDT already. Docs have it in "Tips and Tricks (JDT)". I guess I didn't find it because I tried ctrl+space only, since no problem marker was visible I didn't get the idea that Ctrl+1 (quickfix) would do it. Also, the text hover over a misspelled word just says "...is not spelled correctly" but gives no hint on how to fix it automatically. Also, the "Tips and Tricks (JDT)" docs say: "You can make the dictionary also available to the content assist." - but I did not find a way how to do it. I'm wondering whether it would make sense to file a bug asking to make these things more prominently visible for novice users...
Excellent to see this! Will consider for New & Noteworthy (added note).
