Bug 19451 - [ExternalTools] configuration dialog should not allow cancel.
Summary: [ExternalTools] configuration dialog should not allow cancel.
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Simon Arsenault CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks: 19454
  Show dependency tree
 
Reported: 2002-06-05 23:55 EDT by Chris McLaren CLA
Modified: 2002-09-18 13:59 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris McLaren CLA 2002-06-05 23:55:32 EDT 
clean F2

it is non-intuitive that the external tools configuration dialog allows you to 
cancel changes. as well, if you edit a tool and change a property, such 
as 'tool location' for instance, this change is NOT being cancelled - a serious 
inconsistency in the UI.

the configuration dialog should have an OK button only. cancel is used to 
revert changes within a single dialog only.
Comment 1 Simon Arsenault CLA 2002-06-06 13:46:21 EDT 
When you press Cancel on the configuration dialog, it should ignore changes 
done to an external tool edit. We need someway to back out of removing an 
external tool.

Defer until after release 2.0  We should consider how the UI should be for this 
dialog to handle all these cases.
Comment 2 Simon Arsenault CLA 2002-06-06 14:50:37 EDT 
Got more details from Chris. The remove button should have a confirmation 
dialog when pressed. With that, we do not need the Cancel button. To be 
considered as part of the minor UI enhancements for F3.
Comment 3 Simon Arsenault CLA 2002-09-06 15:10:08 EDT 
Not applicable in new external tool support.

Note: new external tool work is not yet released to the head stream and won't 
for a while yet.