Bug 191726 - use strike-through font for resolved dependent tickets
Summary: use strike-through font for resolved dependent tickets
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.0 M2   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 2.3   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 167354 204694 212975 216693 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-08 11:34 EDT by Martin Kobele CLA
Modified: 2008-01-27 02:11 EST (History)
5 users (show)

See Also:


Attachments
patch for 167354 (3.74 KB, patch)
2008-01-06 15:38 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (3.73 KB, application/octet-stream)
2008-01-06 15:42 EST, Frank Becker CLA
no flags Details
encapsulated strike through logic in TaskListHyperlink (13.21 KB, patch)
2008-01-09 14:25 EST, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (5.31 KB, application/octet-stream)
2008-01-09 14:25 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Kobele CLA 2007-06-08 11:34:01 EDT
Bugzilla shows resolved dependent tickets with a strike-through font.
Could we have that as well please :)

Would that slow it down a lot because it would have to query all the dependent bug tickets for their status....
Comment 1 Martin Kobele CLA 2007-06-08 11:35:23 EDT
oh I see that mylyn shows a popup with the ticket summary of the dependent ticket when you hover with the mouse over the link to the ticket. so it already had queried the bug ticket for the summary.
Comment 2 Mik Kersten CLA 2007-06-08 12:10:05 EDT
Martin: I think that you get the award of first official user's use of the "Mylyn" name on a bug report :)

Yes, assuming that we can set a strikethrough font on a hyperlink this is relatively straightforward.
Comment 3 Eugene Kuleshov CLA 2007-06-08 13:15:19 EDT
Please make possible to turn off all uses of striketrough.
Comment 4 Mik Kersten CLA 2007-06-08 17:19:47 EDT
That's bug 169916, I'll comment there.
Comment 5 Steffen Pingel CLA 2007-12-14 01:41:03 EST
*** Bug 167941 has been marked as a duplicate of this bug. ***
Comment 6 Steffen Pingel CLA 2007-12-14 01:42:52 EST
Rob, we need this for JIRA as well. We should consider to generalize the rendering for links to subtasks / dependent tasks.
Comment 7 Steffen Pingel CLA 2007-12-14 01:43:13 EST
*** Bug 212975 has been marked as a duplicate of this bug. ***
Comment 8 Eugene Kuleshov CLA 2007-12-14 02:21:43 EST
There is some difference in the implementation how dependent (and other linked tasks) are shown in bugzilla and in jira editors. Bugzilla is using bunch of hyperlink widgets on a composite, while in JIRA it is just a SourceViewer with a standard JIRA hyperlink detector (the latter is simply more compact in the UI). Another difference is that in JIRA these hyperlinks can't be submitted as part of the regular submission like it is done in bugzilla now, that is why I made all linked task fields readonly in the JIRA editor when implemented this.
Comment 9 Steffen Pingel CLA 2008-01-06 15:06:23 EST
*** Bug 167354 has been marked as a duplicate of this bug. ***
Comment 10 Steffen Pingel CLA 2008-01-06 15:07:46 EST
*** Bug 204694 has been marked as a duplicate of this bug. ***
Comment 11 Frank Becker CLA 2008-01-06 15:38:39 EST
Created attachment 86276 [details]
patch for 167354

While I create the patch for bug 167354 the bug get closed and marked as duplicate. So I post the patch here.
Comment 12 Frank Becker CLA 2008-01-06 15:42:02 EST
Sorry no context was included. So here the context of bug 167354.
Comment 13 Frank Becker CLA 2008-01-06 15:42:07 EST
Created attachment 86277 [details]
mylyn/context/zip
Comment 14 Eugene Kuleshov CLA 2008-01-06 23:05:10 EST
Can we please make any striketrough optional. It makes it harder to read text when small font is used (8pt and smaller). 

BTW, I think there is related issue somewhere, that suggesting to convert related bug fileds to the SourceEditors with in-place hyperlinking.
Comment 15 Mik Kersten CLA 2008-01-09 13:29:31 EST
Great to see this Frank!  It will be a significant help.

(In reply to comment #14)
> Can we please make any striketrough optional. It makes it harder to read text
> when small font is used (8pt and smaller).

Eugene: Yes, but that's bug 217041 and should be done at a global level, so let's leave it aside from this.  I'll follow up on that bug report.
Comment 16 Steffen Pingel CLA 2008-01-09 14:25:10 EST
Created attachment 86496 [details]
encapsulated strike through logic in TaskListHyperlink
Comment 17 Steffen Pingel CLA 2008-01-09 14:25:15 EST
Created attachment 86497 [details]
mylyn/context/zip
Comment 18 Steffen Pingel CLA 2008-01-09 14:31:49 EST
Thanks for the great patch Frank!
Comment 19 Steffen Pingel CLA 2008-01-09 14:34:53 EST
I merged your code into TaskListHyperlink so we have a single class that encapsulates the rendering of hyperlinks for tasks. Hyperlinks can be created through the new method AbstractRepositoryTaskEditor.createTaskListHyperlink(). Please take a look at the attached patch or the TaskListHyperLink class in CVS to verify that it still works as intended. 
Comment 20 Eugene Kuleshov CLA 2008-01-09 16:15:13 EST
Hmm. No one responded to my question about using SourceEditors to show hyperlinks instead of two-row rendering. Are SourceEditors been considered?
Comment 21 Steffen Pingel CLA 2008-01-09 16:52:19 EST
I am not aware that using SourceEditors is part of the 2.3 plan but I would prefer to discuss the priority on the corresponding bug.
Comment 22 Willian Mitsuda CLA 2008-01-21 23:08:48 EST
Bug#167941, which was marked dup of this one, was requesting also using strike-through font for bug hyperlinks inside comments too.

I think it is an important feature because it makes easy for you to see if some related bug was resolved or not as you read the comments.

Should I reopen that?
Comment 23 Steffen Pingel CLA 2008-01-21 23:19:46 EST
Sorry, I missed that when I marked the bug as a duplicate. Please go ahead an reopen bug 167941.
Comment 24 Willian Mitsuda CLA 2008-01-27 01:41:40 EST
FYI, I opened bug#216693 for the missed "blocks" section case, for UI consistency.
Comment 25 Steffen Pingel CLA 2008-01-27 02:11:08 EST
*** Bug 216693 has been marked as a duplicate of this bug. ***