Bug 190831 - Update Configurator reconciles platform.xml with newer features even when the site is marked not updateable.
Summary: Update Configurator reconciles platform.xml with newer features even when the...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P2 critical (vote)
Target Milestone: 3.3 RC4   Edit
Assignee: Platform-Update-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 170000 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-04 11:29 EDT by Nalini Ganapati CLA
Modified: 2007-06-05 16:36 EDT (History)
1 user (show)

See Also:
dj.houghton: review+
john.arthorne: review+
john.arthorne: review+

Attachments
Patch to not reconcile/update when a site has updateable set to false. (1.52 KB, patch)
2007-06-04 11:35 EDT, Nalini Ganapati CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nalini Ganapati CLA 2007-06-04 11:29:30 EDT 
This is a regression from 3.2.2 when a fix for Bug 166852 was made available. Basically, a site in platform configuration is not reconciled/updated when updateable=false. See attachment for a suggested patch.

I would like to contribute a junit for this problem, please let me know about ways on doing this.
Comment 1 Nalini Ganapati CLA 2007-06-04 11:35:30 EDT 
Created attachment 69970 [details]
Patch to not reconcile/update when a site has updateable set to false.
Comment 2 Dejan Glozic CLA 2007-06-04 11:52:00 EDT 
JUnit tests for Update are in org.eclipse.update.core.tests.
Comment 3 Dejan Glozic CLA 2007-06-04 11:58:46 EDT 
A candidate for RC4
Comment 4 Dejan Glozic CLA 2007-06-05 10:04:16 EDT 
A well encapsulated patch for a concrete scenario: the code modification only comes into effect if the install location is not updatable. In other words, it does not affect out of the box Eclipse case.
Comment 5 Dejan Glozic CLA 2007-06-05 11:08:35 EDT 
*** Bug 170000 has been marked as a duplicate of this bug. ***
Comment 6 John Arthorne CLA 2007-06-05 11:34:54 EDT 
Just to clarify, is this just a case of a fix that was released for 3.2.2, but never put in HEAD for 3.3?
Comment 7 Dejan Glozic CLA 2007-06-05 11:46:04 EDT 
Yes, although Nalini recognized that we need to cover another spot with the same 'isUpdatable' check. Otherwise it is the same fix.
Comment 8 John Arthorne CLA 2007-06-05 12:06:11 EDT 
Ok, looks simple and safe. +1 for RC4
Comment 9 Dejan Glozic CLA 2007-06-05 14:02:11 EDT 
Released.