Bug 166852 - Update Configurator reconciles platform.xml with newer features even for sites that have USER-INCLUDE Policy and have explicit inclusion plugin lists.
Summary: Update Configurator reconciles platform.xml with newer features even for site...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Platform-Update-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-05 16:10 EST by Nalini Ganapati CLA
Modified: 2007-01-09 14:15 EST (History)
6 users (show)

See Also:

Attachments
Patch to not reconcile when updateable attribute is false for a given site (1.12 KB, patch)
2006-12-08 17:34 EST, Nalini Ganapati CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nalini Ganapati CLA 2006-12-05 16:10:24 EST 
Platform.xml seems to get reconciled everytime with new features even for sites that have plugin lists associated with them. When Help:Manage Configuration is invoked, you see all the new features listed for the sites with errors in them. The solution is to not reconcile new features for sites that have USER-INCLUDE policy and explicit inclusion plugin lists specified. 

We worked around this issue by setting the transient attribute to true for the configuration. But, this has its own set of problems because the attribute is set for the entire platform configuration and it does not allow new extensions to be picked from the LINKS folder. Also, a side effect of setting this transient attribute seems to be that the information cached regarding the plugins/features is never updated and eclipse has to be invoked with a -clean option even when Help:Find and Install is used to install/update features.

To reproduce :
1. Add a new site to platform.xml with USER-INCLUDE policy and specify the plugins explicitly for that site in platform.xml 
2. Bring up eclipse and check that everything comes up as desired using About Eclipse:Plugin-Details/Feature Details, Help:Manage Configuration, etc.
3. Exit eclipse.
4. Drop in a new set of features/plugins to the same site.
5. Bring up eclipse again and check that the correct set of plugins are installed.
6. Bring up Help:Manage Configuration and notice that the new features from step 4 are shown with errors on them because the plugins associated with them are not installed.

I can provide a patch for this problem if necessary.
Comment 1 Nalini Ganapati CLA 2006-12-08 17:34:20 EST 
Created attachment 55343 [details]
Patch to not reconcile when updateable attribute is false for a given site

I am including a simple patch for solving this problem. Basically, when a site is marked "not updateable", the update configurator does not reconcile.
Comment 2 Nalini Ganapati CLA 2006-12-08 17:39:46 EST 
Adding Peter M. and Pascal to the list. Would it be possible to include the solution to this problem in a patch to 3.2.1?
Comment 3 Mike Wilson CLA 2006-12-18 11:26:22 EST 
... or at least in 3.2.2?
Comment 4 Dejan Glozic CLA 2007-01-09 14:15:01 EST 
Released in 3.2_Maintenance.