Bug 18830 - [MenuMgmt] Early plugin activation creating dynamic submenus
Summary: [MenuMgmt] Early plugin activation creating dynamic submenus
Status: RESOLVED DUPLICATE of bug 53979
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P4 major (vote)
Target Milestone: ---   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate, performance
: 27360 27460 28074 (view as bug list)
Depends on: 29709
Blocks: 27460
  Show dependency tree
 
Reported: 2002-06-03 13:45 EDT by John Arthorne CLA
Modified: 2007-06-14 11:04 EDT (History)
6 users (show)

See Also:


Attachments
Stack trace of plugin activation (4.15 KB, text/plain)
2002-06-03 13:46 EDT, John Arthorne CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2002-06-03 13:45:38 EDT
Build 20020602 (F2)

If you start a new workspace, the external tools plugin gets activated on 
startup.  This appears to be related to updating the menu contribution provided 
by this plugin. Plugins should not be activated just to create a menu item.  You 
can verify this by adding the following to your .options file:

org.eclipse.core.runtime/debug=true
org.eclipse.core.runtime/timing/startup=true

I will attach the stack trace from the activation.
Comment 1 John Arthorne CLA 2002-06-03 13:46:19 EDT
Created attachment 1185 [details]
Stack trace of plugin activation
Comment 2 Nick Edgar CLA 2002-06-03 14:20:08 EDT
Only occurs with dropdown tool items (class WWinPluginPulldown).
Too risky to change at this stage.  The Debug items use this too.

This could definitely be contributing to our startup time though.
E.g. Debug will be activated when in Java perspective.
Comment 3 Randy Giffen CLA 2002-08-12 10:41:21 EDT
Reopened for investigation
Comment 4 Simon Arsenault CLA 2002-11-14 10:58:33 EST
Notice that the action being contributed is both for the tool bar and menu bar. 
When the tool bar is being populated, the pull down menu of the tool item 
representing the action is not created at that time and therefore the delegate 
is not created nor is the plugin loaded.

But because its also an action for the menu bar and states it's a cascading 
menu item, the menu bar update code forces the delegate to load so the menu is 
properly updated.

Until we address the issue of dynamic menu contributions, I suggest we hold off 
doing anything on this at the moment. Therefore, downgrading the priority.
Comment 5 John Arthorne CLA 2002-12-02 11:14:59 EST
See also bug 27460
Comment 6 Jared Burns CLA 2002-12-02 16:38:09 EST
Why does the menubar code ask for the children before the menu is shown?
Comment 7 Simon Arsenault CLA 2002-12-03 09:31:14 EST
There were lots of reasons. For example, keeping the accelerators up-to-date. 
The problem only started showing up a few months ago it seems because of some 
changes done to support the cheveron menu.

Nevertheless, we may have a potential workaround and we are looking at true 
support for dynamic menus (the ones giving us this problem at the moment)
Comment 8 Nick Edgar CLA 2002-12-06 15:17:26 EST
Moving to Eduardo for the fix to lazily populate menus.
Filed bug 27867 for future work to improve the management of dynamic items.

Comment 9 Nick Edgar CLA 2002-12-09 10:42:33 EST
*** Bug 27360 has been marked as a duplicate of this bug. ***
Comment 10 Eduardo Pereira CLA 2003-01-06 11:34:04 EST
We can't lazy populate the menu in this case. We need a real solution for this 
problem with new API. 
Comment 11 Simon Arsenault CLA 2003-01-06 13:57:42 EST
*** Bug 28074 has been marked as a duplicate of this bug. ***
Comment 12 Simon Arsenault CLA 2003-01-07 10:54:36 EST
To investigate and come up with a "light-weight" proposal for 2.1 which will 
allow us to extend in a future release.
Comment 13 Douglas Pollock CLA 2003-12-03 13:10:34 EST
This obviously did not make it into 2.1.  This will be considered under Bug
36968 for 3.0, but might not make it into the final release.
Comment 14 Douglas Pollock CLA 2004-05-19 10:32:09 EDT
Deferring until after M9.
Comment 15 Michael Van Meekeren CLA 2004-05-21 13:09:13 EDT
Marking as LATER
Comment 16 Darin Wright CLA 2007-06-14 10:36:55 EDT
*** Bug 27460 has been marked as a duplicate of this bug. ***
Comment 17 John Arthorne CLA 2007-06-14 11:03:53 EDT
Reopening to mark as dup.
Comment 18 John Arthorne CLA 2007-06-14 11:04:17 EDT

*** This bug has been marked as a duplicate of bug 53979 ***