Bug 185966 - [linked mode] Consider making dashed line for linked mode master the default
Summary: [linked mode] Consider making dashed line for linked mode master the default
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: fix candidate
Keywords:
Depends on: 205728 184492
Blocks:
  Show dependency tree
 
Reported: 2007-05-08 11:17 EDT by Dani Megert CLA
Modified: 2019-09-06 16:05 EDT (History)
2 users (show)

See Also:


Attachments
Screenshot (216.40 KB, image/png)
2007-06-15 08:34 EDT, Markus Keller CLA
no flags Details
Screenshot (6.75 KB, image/png)
2007-06-15 12:00 EDT, Markus Keller CLA
no flags Details
add no-dash-zone to corners (3.19 KB, patch)
2007-06-15 12:06 EDT, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-05-08 11:17:51 EDT
The new dashed line drawing strategy around the master linked position is better recognizable and is visible for selected and for unselected text.

We should consider making this the default.
Comment 1 Dani Megert CLA 2007-06-15 07:43:47 EDT
Markus, please add your comments here. You had some negative comments about this recently.
Comment 2 Markus Keller CLA 2007-06-15 08:34:00 EDT
Created attachment 71442 [details]
Screenshot

(In reply to comment #1)
The dashed lines look strange with short names and small editor fonts: On first sight, they look like a bunch of randomly placed dashed, since their rectangular form is not completely visible.

A fix could be to make sure all corners are drawn with full 3 pixels of horizontal and vertical lines and only start with dashes after the 3 pixels adjacent to the corners.
Comment 3 Markus Keller CLA 2007-06-15 12:00:56 EDT
Created attachment 71477 [details]
Screenshot

Previous attachment was BMP but was submitted as PNG. This happened because MS Paint was so stupid and saved a BMP into a .png file, and Firefox was so stupid and rendered a file with mime type image/png as BMP without saying a word...
Comment 4 Markus Keller CLA 2007-06-15 12:06:50 EDT
Created attachment 71480 [details]
add no-dash-zone to corners

Here's a patch to experiment with no-dash-zones in corners.
Comment 5 Dani Megert CLA 2008-04-24 06:08:50 EDT
Comment on attachment 71480 [details]
add no-dash-zone to corners

Marking patch obsolete as drawing is now done by SWT.
Comment 6 Dani Megert CLA 2008-04-24 06:15:06 EDT
Too late to change defaults. Will make final decision once bug 205728 is fixed.
Comment 7 Dani Megert CLA 2008-04-26 06:15:57 EDT
.
Comment 8 Eclipse Webmaster CLA 2019-09-06 16:05:43 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.