Comment 1 Markus Keller 2007-04-27 13:53:13 EDT

Created attachment 65243 [details]
Implementation

Comment 2 Markus Keller 2007-04-27 13:56:46 EDT

See attachment 65224 [details] from bug 181830 for a screenshot.

Comment 3 Dani Megert 2007-04-30 11:20:06 EDT

Thanks for the patch. I agree that better feedback would be nice but I don't like this dashed line and especially that it looks animated when typing.

In addition it is really too late in the release cycle to change this now as it would affects all linked editing.

We also have to test that this/a new drawing strategy scales when a user chooses it to indicate e.g. errors or warnings.

Comment 4 Dani Megert 2007-04-30 17:34:40 EDT

I have released the patch but remove the code that sets it as default.
This allows us to further test this.

Comment 5 Dani Megert 2007-05-03 03:18:49 EDT

The dashed line behaves differently on each platform. We can leave it but not as default as this affects every client that uses the linked mode UI.

If we make this the default in 3.4 we should try to implement it in a way that it behaves the same on all Platforms.

Comment 6 Dani Megert 2007-05-07 04:30:19 EDT

Note that the dashed mode also needs to support the I-beam, e.g. in this case:

	/**
	 */
	public void foo() throws IOException {
		throw new IOException();
	}

and then 'Add all missing tags'

Comment 7 Markus Keller 2007-05-07 06:54:37 EDT

Created attachment 66080 [details]
Fix for animation, platform-dependent drawing, and IBeam

Comment 8 Dani Megert 2007-05-08 11:20:03 EDT

Martin, please approve the improved drawing strategy.

I want to close this bug for RC1. I've opened bug 185966 on whether to make this the default in 3.4.

Comment 9 Martin Aeschlimann 2007-05-08 11:39:09 EDT

patch looks good

Comment 10 Dani Megert 2007-05-09 03:28:53 EDT

Fixed in HEAD.
Available in builds > N20070509-0010.

Comment 11 Dani Megert 2007-05-15 05:59:01 EDT

Verified in I20070515-0010.