Bug 185353 - Closing projects is very slow
Summary: Closing projects is very slow
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-03 10:34 EDT by Ritchie Schacher CLA
Modified: 2007-06-27 07:58 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ritchie Schacher CLA 2007-05-03 10:34:38 EDT 
Build ID: I20070209-1006

Steps To Reproduce:
When I closed 75% of the projects in my workspace, it took what seemed like 5-10 minutes.  I have a WS with a very large number of projects.

My esteemed colleague ran a profiler and determined that this is a bug in eclipse. Most of the time is spent inside 
PackageFragmentRoot.setSourceAttachmentProperty setting this property over and over again.


More information:
Comment 1 Philipe Mulet CLA 2007-05-03 10:41:32 EDT 
We made lots of improvements near closing projects recently.
Comment 2 Philipe Mulet CLA 2007-05-03 10:44:23 EDT 
Looks like a dup of bug 181900.
Ritchie - can you give it a try on 3.3M7 ? Even last I-build will do the trick.
Comment 3 Jerome Lanneluc CLA 2007-05-03 10:45:56 EDT 
Yes, this is the same problem as reported in bug 181900 which is a dup of bug 145329

*** This bug has been marked as a duplicate of bug 145329 ***
Comment 4 Ritchie Schacher CLA 2007-05-03 10:50:26 EDT 
Thanks, we have not yet adopted M7 but I will try it out in the future.  I trust you guys if you say it's fixed.
Comment 5 Olivier Thomann CLA 2007-05-03 21:26:16 EDT 
Verify for 3.3M7 with I20070503-1400.
Comment 6 Ritchie Schacher CLA 2007-06-26 10:15:59 EDT 
Still seeing same problem.
Comment 7 Eric Jodet CLA 2007-06-26 10:34:05 EDT 
(In reply to comment #6)
using Build id: I20070608-1718
in my 440+ projects workspace, closed 300 projects in less than 10 seconds.
It sounds like fast to me.
Comment 8 Jerome Lanneluc CLA 2007-06-27 07:58:16 EDT 
Problem is different this time. I opened bug 194598 to track it.
I'm closing this bug since the problem with PackageFragmentRoot.setSourceAttachmentProperty is fixed.