Bug 194598 - 44% of time closing projects spent in LaunchManager#resourceChanged
Summary: 44% of time closing projects spent in LaunchManager#resourceChanged
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-06-27 07:57 EDT by Jerome Lanneluc CLA
Modified: 2007-07-19 14:39 EDT (History)
1 user (show)

See Also:

Attachments
patch for 3.3.1 maintenance (4.41 KB, patch)
2007-07-09 14:10 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2007-06-27 07:57:13 EDT 
I20070625

I have a workspace where closing more than 300 projects takes 3 minutes. Usually closing this many projects takes around 10 seconds. Let me know and I can provide you with the workspace.

Exact steps to reproduce are:
1. Start the given workspace
2. Ctrl+Shit+T and wait until indexing is done 
3. Select all projects under working set 'Other Projects'
Observe: The operation takes 3 minutes on my T60p

Running step 3 under a profiler shows that 44% of the time is spent in LaunchManager#resourceChanged. I have the Yourkit snapshot available as well.
Comment 1 Darin Wright CLA 2007-06-27 10:12:17 EDT 
Changing to 3.3, since build is I20070625.
Comment 2 Michael Rennie CLA 2007-06-27 15:15:00 EDT 
I used my large workspace of just over 300 projects and found that only 5% of the total time was in LaunchManager#resourceChanged, but did find that 32% of the time was spent persisting  the launch history over and over and over again (once each time a project was closed).

I released a fix to HEAD that resolves the launch history persistence problem. Jerome could you post your YourKit snapshot so I can compare it to mine?
Comment 3 Darin Wright CLA 2007-06-27 16:11:44 EDT 
Marking as 3.3.1 candidate
Comment 4 Jerome Lanneluc CLA 2007-06-28 04:54:13 EDT 
Posted Yourkit snapshot and workspace on internal site for Michael.
Comment 5 Michael Rennie CLA 2007-07-09 14:10:24 EDT 
Created attachment 73356 [details]
patch for 3.3.1 maintenance
Comment 6 Michael Rennie CLA 2007-07-09 16:17:49 EDT 
released to 3.3.1 maintenance
Comment 7 Michael Rennie CLA 2007-07-09 16:19:02 EDT 
when comparing the traces it was indeed the save participant that was causing all of the work.

marking fixed, please verify Darin W
Comment 8 Darin Wright CLA 2007-07-19 14:39:38 EDT 
Verified.