Bug 180300 - [StatusHandling] ErrorSupportPart should handle a StatusAdapter and not an IStatus
Summary: [StatusHandling] ErrorSupportPart should handle a StatusAdapter and not an IS...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, contributed
Depends on:
Blocks:
 
Reported: 2007-03-30 16:50 EDT by Christophe Elek CLA
Modified: 2008-03-28 07:26 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Elek CLA 2007-03-30 16:50:12 EDT 
There is a discrepency between the 2 API we have

The handle method of a StatusHandler accepts a StatusAdapter
the createPartControl of the ErrorSupportPart accepts an IStatus

We should review for 3.4
Comment 1 Krzysztof Daniel CLA 2007-08-21 08:43:28 EDT 
Chris, do you mean ErrorSupportProvider?
Comment 2 Christophe Elek CLA 2007-09-05 10:22:26 EDT 
Krzystof,
Maybe :) I think we changed the API :)
The issue here is that when I call the StatusHandler API , I pass a StatusAdapter
When I implement my provider, I receive a IStatus

Makes sense ?
Comment 3 Krzysztof Daniel CLA 2008-02-26 10:32:37 EST 
ErrorSupportProvider is a jface class and seems to be designed for jface ErrorDialog. 

Fix for bug 191684 introduces AbstractStatusAreaProvider which is derived from ErrorSupportProvider and accepts both StatusAdapter and IStatus.

I think this removes API problem (jface providers for jface error dialog, workbench providers for workbench error dialog).

In case of any concerns please reopen.
Comment 4 Krzysztof Daniel CLA 2008-03-28 07:26:55 EDT 
28-03-2008 verified by code inspection. ErrorSupportPart does not exist anymore, now see AbstractStatusAreaProvider.