Community
Participate
Working Groups
Status Dialog it lacks some functionality: * selection change is not propagated to ErrorSupportProvider * there is no possibility of adding actions that should execute after closing the dialog - I would like to be able to launch Troubleshoot wizard or something like that. Or even simple workspace synchronization. Status Dialog is ugly. I think it would be nice, if the details were displayed as sections (like in compiler->errors/warnings preference page).
We need more feedback from users for these issues. The idea was that the Platform provides rather simple solution that can be extended in particular products. But I think we can add some useful features like actions at closing etc. Sections in this default dialog are not good in my opinion. We should use similar approach as in the error log view. In the dialog we should use a list sorted by the occurrence date. Anyway new ideas and patches are welcome Krzysztof ;-)
Created attachment 82884 [details] A Patch introducing new status dialog
Krzysiek, please attach the icons.
Created attachment 82952 [details] Show support icon Should be placed there \org.eclipse.ui\icons\full\dtool16\show_support.gif
Some comments. 1. I can't extend the details area vertically. 2. When there is only one error (no list), the left and top margins for its description (below the header) are too small. I think that the description should be in the same place as the first element on the list when more errors occurred. 3. Maybe this is a matter of the test tool, but there is no title in the header for warnings (sometimes). 4. When more errors occur, it would be useful to see the issue type icon next to the element in the list (it can be a new bug).
Created attachment 83437 [details] Patch Issues 2 and 3 fixed. I would like consider 4 as RFE when this patch will be applied. Point one (resizing) - I like this idea but this seems to be quite difficult, since I need to create a dialog with two trays. Or maybe you have idea how to solve that using simpler approach?
Created attachment 83503 [details] Patch I have made the details area to resize proportionally when the dialog is resized. Is that acceptable?
It is. However I have still some comments. 1) Open the dialog with more than one error. When the details area is opened, the dialog increases its size and when the details are closed, the dialog returns to the initial size. When you resize the dialog, something strange happens with its size when the details are opened and closed. 2) I would organize the layout trying to avoid situations like the one on the attached picture. 3) I think that the previous way was better anyway. The details part height is constant (more like the tray). I think that we can a similar divider between the list and the details, so we could change the ratio if necessary. I think that issue 3 could be a separate bug.
Created attachment 83618 [details] the picture
Created attachment 85054 [details] Patch I think I have addressed Tod remarks... Szymon, could you review?
Created attachment 85543 [details] Patch I have extracted interface from WorkbenchStatusDialog to remove implementation details from public packages and make eventuall changest required to testing easier.
Created attachment 86407 [details] Patch Slightly modified previous. Testing made possible.
Created attachment 86552 [details] Patch - dialog based on TrayDialog (not on TitleAreaDialog)
Created attachment 86553 [details] mylyn/context/zip
Created attachment 86808 [details] Some issues addressed
Created attachment 88534 [details] Patch everything placed in internal packages
Created attachment 89717 [details] Patch Again in the public packages
(In reply to comment #17) > Created an attachment (id=89717) [details] > Patch > > Again in the public packages > It doesn't contain classes from the internal packages.
Created attachment 90368 [details] Fixed positioning
Created attachment 90461 [details] Small changes
I made some changes in the latest patch. Javadocs were not sufficient, but I updated them. New issues arising from that fix will be handled in separate bugs.
28-03-2008 verified using status generator from org.eclipse.ui.examples.statushandlers.testtool.
