Bug 17717 - [ExternalTools] Ant script cancelation should be better handled
Summary: [ExternalTools] Ant script cancelation should be better handled
Status: RESOLVED DUPLICATE of bug 16919
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
: 18069 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-05-24 11:35 EDT by Rodrigo Peretti CLA
Modified: 2002-09-18 13:59 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo Peretti CLA 2002-05-24 11:35:12 EDT 
build F1

Right now when the user hits the Cancel button on the Ant Wizard, a not so 
nice "Build Failed - see log for details" message dialog is shown. We could 
coordinate some changes between Platform UI and Ant Core to better support 
that. My suggestion is to just stop the script execution and do not show any 
messages - the log will be around if the user wants to check it (I believe 
this was the old behaviour).

Suggested steps are:
1) fix bug 17481
2) move class BuildCanceledException from Platform UI to Ant Core
3) if monitor is canceled Ant Core throws BuildCanceledException
4) UI checks instanceof on exceptions thrown by AntRunner in order to decide 
what to do

Recomend for 2.0.
Comment 1 Nick Edgar CLA 2002-05-28 09:56:04 EDT 
Reassigning for items 2 and 3.
Generally we use OperationCanceledException here.  Should not have to introduce 
a new exception.
Comment 2 Rodrigo Peretti CLA 2002-05-28 10:51:58 EDT 
The code in Ant Core now throws a OperationCanceledException if the monitor is 
canceled. Moving back to Platform UI for item (4).
Comment 3 Rodrigo Peretti CLA 2002-05-28 12:22:37 EDT 
*** Bug 18069 has been marked as a duplicate of this bug. ***
Comment 4 Nick Edgar CLA 2002-05-28 12:57:39 EDT 

*** This bug has been marked as a duplicate of 16919 ***