Community
Participate
Working Groups
20070503 The following blocking dialog was reached on 'Save' while a build was running. See screenshot contains the following UI issues: - No label for first entry. What about 'User operation' - The description should use single quotes for consistency with other labels in Eclipse.
Created attachment 60284 [details] screenshot
- the dialog title should better not form a sentence with a verb, but more something like 'Blocked User Operation'
We are taking the current task name from the monitor but it is becoming clearer that many of these cases are happening before the monitor is initialized. Some default text is a good idea. Thanks for the feedback Martin.
*** Bug 181165 has been marked as a duplicate of this bug. ***
Or 'Pending/Waiting User Operation' ? Blocked feels a bit too harsh. Shouldn't we also retaliate against progress monitors with missing labels ?
We should certainly log seperate bugs to components whose monitors block without any task information for us to show.
See Bug 182568 for the offending empty progress monitor. I have changed our logic to check for null as well as empty Strings. Currently (i.e. since 3.0) we take the shell title for the name of the unlabeled entry field. If you think this is not the right direction please log a bug for your suggested change and we can make it take Philippes suggested wording. Fixed for build >20070316 To replicate do the following 1) Import a lot of plug-ins and fragments 2) Change an editor and save it.
What's an example of a shell title?
Generally it would be the title of the workbench window. As Phillipe says the best option is to chase down the monitors that have an empty task name.
I agree it's best to chase down progress monitors with missing task messages. But I doubt that the shell title is second best. I don't think the window title is of any help here. What about 'Pending/waiting user operation'? Note that sentence capitalization is correct here, but not title capitalization. Another reason to not take a shell title...
That would be fine for me. I just kept the shell title because that is what we used to use. Philippe what is your opinion?
I was thinking of a default label, no shell title; but I am not a UI expert, so cannot break the tie here (pls ask some UI person). Also, when mentionning 'Pending/Waiting' I was thinking of either 'Pending' or 'Waiting' <g> Pls run this by some native speaker. My claim against 'Blocked' is that it sounded like deadlocked or sthg like that...
Waiting would be the better word I would think. There is no tie to break - Martin and I agree. So if you abstrain we will go with the result of the 2-1-0 vote <grin>. Reopening to change wording.
Fixed the String for build >20070418
Verified in I20070430-0010
