Description Martin Oberhuber 2007-02-27 06:14:48 EST

ISystemRegistry contains lots of methods for getting hosts, systemTypes or subsystemConfigurations based on various query criteria. Many of these are redundant, but some important ones are missing. The API should be cleaned up:

1. API docs should specify that ISystemRegistry is not intended to be
   implemented or subclassed by clients.
2. There should be one clearly defined and documented API method for getting
   the ISystemRegistry (currently: RSEUIPlugin, RSECorePlugin, SystemStartHere, 
   SystemRegistry).
3. The actual SystemRegistry implementation should be internal. This will
   require returning a proper interface in RSEUIPlugin.
4. All methods taking a system type name as parameter should be deprecated,
   and replaced by methods taking an IRSESystemType instance:
   - getHostsBySystemType(IRSESystemType), 
   - getSubsystemConfigurationsBySystemType(IRSESystemType)
5. Wherever there are duplicate methods get... with a variant taking an 
   interface (e.g. ISystemProfile) and a name (e.g. profileName), there 
   should be only ONE method in the API, preferrably taking the interface.
   Clients who have a name and need to query something from the Registry
   should then do something like
      ISystemProfile profile = registry.getProfileByName(name);
      IHost[] hosts = registry.getHostsByProfile(profile);
6. There should be methods
   - getSubsystems(IHost host, Class subsystemInterface) 
   - getSubSystemConfigurations(IHost host, Class subsystemInterface)
   in order to simplify or make obsolete corresponding implementations in
   RemoteFileUtility, RemoteCommandHelpers. The method would be analogous
   to the current getServiceSubSystems() method. An empty subsystemInterface
   parameter (null) could be used to replace the current getSubsystems(IHost)
   and getSubSystemConfigurations(IHost) methods.