Bug 175262 - [api] IHost.getSystemType() should return an IRSESystemType
Summary: [api] IHost.getSystemType() should return an IRSESystemType
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 170918 175680 180688 180690 184095
  Show dependency tree
 
Reported: 2007-02-23 07:54 EST by Uwe Stieber CLA
Modified: 2008-08-13 13:17 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Stieber CLA 2007-02-23 07:54:28 EST 
This is far tracking necessary work for identifying system types consistently using the system type id instead of the system type name throughout the RSE open source implementation.

The main point which blocks further refactorings towards this goal is the IHost interface and implementers (Host and DummyHost). The IHost.getSystemType() API should be made
- either deprecated and replaced by a getSystemTypeId() or
- returning the IRSESystemType object.

For compatibility reasons, either the persistence manager or the IHost implementors needs to translate from the system type name to the system type id if working with older workspaces.
Comment 1 Martin Oberhuber CLA 2007-02-23 08:08:36 EST 
I'd vote for keeping the method but making it return an IRSESystemType.
At least from an API perspective, this is the cleanest solution, and I hope that implementing it isn't too hard.

With 2.0 we're breaking APIs anyways, and this way there's no need to deprecate anything since clients who use the method will run into a compile error (where the fix is really easy: if they don't want to change too much, users would just
replace
   String name = myHost.getSystemType();
by
   String name = myHost.getSystemType().getName();

whereby getName() would be deprecated, of course.
Comment 2 Martin Oberhuber CLA 2007-04-03 07:21:33 EDT 
Fixed: [175262][api] IHost.getSystemType() should return IRSESystemType

Found others which operate on String systemType and should be changed:
SystemSignonInformation.getSystemType() --> bug 180688
ISubSystem.getSystemType() --> bug 180690
Comment 3 Martin Oberhuber CLA 2008-08-13 13:17:34 EDT 
[target cleanup] 2.0 M6 was the original target milestone for this bug