Bug 189123 - [api][breaking] Prepare SystemRegistry for move into non-UI: change ISystemRegistry, ISubSystemConfigurationAdapter
Summary: [api][breaking] Prepare SystemRegistry for move into non-UI: change ISystemRe...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on: 189130
Blocks: 170923 175680
  Show dependency tree
 
Reported: 2007-05-25 07:57 EDT by Martin Oberhuber CLA
Modified: 2008-08-13 13:19 EDT (History)
3 users (show)

See Also:
mober.at+eclipse: pmc_approved+
dmcknigh: review+
ddykstal.eclipse: review+
kmunir: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-05-25 07:57:51 EDT 
In order to prepare for moving SystemRegistry into non-UI, some API needs to be adapted:

* Move from ISystemRegistry into ISystemRegistryUI:
	public void showRSEPerspective();
	public void expandHost(IHost conn);
	public void expandSubSystem(ISubSystem subsystem);

* Move from ISubSystemConfigurationAdapter into ISubSystemConfiguration:
        void renameSubSystemProfile(ISubSystemConfiguration, String, String)
Comment 1 Martin Oberhuber CLA 2007-05-25 08:06:48 EDT 
This change has been discussed in committer meeting
http://wiki.eclipse.org/index.php/DSDP/TM/Committer_Phone_Meeting_22-May-2007.

The first part (moving the clearly UI methods into ISystemRegistryUI) has been done already. 

Committers please vote for the second part now for RC2: Moving renameSubSystemProfile from ISubSystemConfigurationAdapter into ISubSystemConfiguration. This is clearly a non-UI callback IMHO, and should not live in the UI-only adapter.
Comment 2 Martin Oberhuber CLA 2007-05-25 09:10:57 EDT 
Change applied for part 2, checkin comment:
[189123][api][breaking] Move renameSubSystemProfile() from UI to Core

Migration notes:
----------------
Use the four methods from their new homes.
- For expanding nodes in the SystemView, note that
  ISystemResourceChangeEvents.EVENT_SELECT_EXPAND can also be used.
- Implementers of ISubSystemConfigurationAdapter or ISubSystemConfiguration:
  Override renameSubSystemProfile() in its new home.
Comment 3 Martin Oberhuber CLA 2008-08-13 13:19:07 EDT 
[target cleanup] 2.0 RC1 was the original target milestone for this bug