Bug 152272 - support saving new unsubmitted tasks offline
Summary: support saving new unsubmitted tasks offline
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P2 enhancement with 3 votes (vote)
Target Milestone: 3.0   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 159698 176818 199674 216568 (view as bug list)
Depends on:
Blocks: 166649 227126
  Show dependency tree
 
Reported: 2006-07-30 08:29 EDT by Eugene Kuleshov CLA
Modified: 2008-06-02 03:28 EDT (History)
9 users (show)

See Also:


Attachments
mylar/context/zip (3.94 KB, application/octet-stream)
2006-10-16 20:11 EDT, Robert Elves CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2006-07-30 08:29:51 EDT
New bugzilla issue editor does not allow to save issue without submitting to server. Nothing happens when I use standard "Save" action and issue just disappear if I close editor and accept option to save isseue from a popup dialog.
Comment 1 Robert Elves CLA 2006-10-04 13:00:39 EDT
*** Bug 159698 has been marked as a duplicate of this bug. ***
Comment 2 Mik Kersten CLA 2006-10-10 23:07:33 EDT
For 0.8 "save" needs to at least pop up a dialog that unsubmitted reports can not be saved.  After that's done let's revisit to figure out whether we can support saving unsubmitted reports offline for 1.0.
Comment 3 Robert Elves CLA 2006-10-16 20:11:00 EDT
Update: A warning dialog is now displayed if a save is attempted on the new bugzilla task editor.
Comment 4 Robert Elves CLA 2006-10-16 20:11:01 EDT
Created attachment 52086 [details]
mylar/context/zip
Comment 5 Robert Elves CLA 2006-11-20 15:01:40 EST
Any further improvement will happen post 1.0.
Comment 6 Mik Kersten CLA 2007-01-23 16:52:51 EST
Rob: let's prioritize M2 things after we put M1 out, and use the 2.0 bucket for now.
Comment 7 Steffen Pingel CLA 2007-03-13 20:04:21 EDT
*** Bug 176818 has been marked as a duplicate of this bug. ***
Comment 8 Robert Elves CLA 2007-06-26 11:02:02 EDT
Deferring. This will require api changes and thorough ui design discussion.
Comment 9 Eugene Kuleshov CLA 2007-08-12 13:17:22 EDT
*** Bug 199674 has been marked as a duplicate of this bug. ***
Comment 10 Steffen Pingel CLA 2008-01-26 17:45:52 EST
*** Bug 216568 has been marked as a duplicate of this bug. ***
Comment 11 Mik Kersten CLA 2008-02-28 16:52:47 EST
Steffen: I think that you already have a good implementation strategy for this?  
Comment 12 Steffen Pingel CLA 2008-02-29 00:51:27 EST
The basic idea is to create a local task for unsubmitted repository tasks. The task data for editing the repository task is stored in the offline storage location for that local task. That solves the problem that there is no unique handle as long as the repository task is unsubmitted. The offline storage will use the handle of the local task.

The additional benefits of that approach is that the unsubmitted task shares all the properties of local tasks, i.e. task activation, contexts and scheduling. On submit the local task is converted to a repository task and the context etc. is copied to the new task. There are some details that need to be worked out. The unsubmitted tasks will propbably need special rules in the task list for visibility and grouping, e.g. always show up under a new "Unsubmitted" node. Also the editor factories need to recognize unsubmitted tasks and we need to decide if the context tab should be shown for those.

A proto-type implementation is in JiraTaskEditor2.
Comment 13 Mik Kersten CLA 2008-02-29 12:06:58 EST
Sounds perfect.  In terms of UI, I think that it could work well enough if they were under a single Unsubmitted node as you suggest, and had a black outgoing arrow with a questino mark.  Having a new UNSUBMITTED state or just reusing OUTGOING would make it easy for the guaranteed visibility rules to do the right thing.
Comment 14 Eugene Kuleshov CLA 2008-02-29 12:34:44 EST
Hmm. How those local tasks will deal with connector-specific task data and editor UI?
Comment 15 Robert Elves CLA 2008-03-06 21:45:06 EST
 (In reply to comment #14)
> Hmm. How those local tasks will deal with connector-specific task data and
> editor UI?
I don't see a problem since in unsubmitted form it is essentially a local task and once submitted becomes a repository task, editable via the appropriate connector editor.
Comment 16 Eugene Kuleshov CLA 2008-03-06 22:23:18 EST
Rob, I am just trying to understand the internals of how it is going to work. For example, one may need to edit an unsubmitted task several times before submitting and for that editing repository-specific editor need to be used. An unsubmitted task would need to have a proper connector type and repository url in order to be editable, so how that fits with the local tasks?
Comment 17 Steffen Pingel CLA 2008-03-06 22:43:06 EST
The connector editor factory will recognize local tasks with outgoing changes and the editor input will have the necessary information to retrieve task data. As I said in comment 12 there are some technical details that need to be addressed but the basics already work for editing JIRA tasks.
Comment 18 Eugene Kuleshov CLA 2008-03-06 23:11:02 EST
(In reply to comment #17)
> ...there are some technical details that need to be addressed...

Sorry about confusion. That is basically what I was asking.
Comment 19 Steffen Pingel CLA 2008-06-02 03:28:03 EDT
This has been implemented as part of the task data API refactoring and works for Bugzilla and JIRA. The design is described in comment 12. Opened bug 234065 to address comment 13. Opened bug 235057 to address remaining problems.