Bug 145540 - [Webapp] Help font does not adjust with system fonts
Summary: [Webapp] Help font does not adjust with system fonts
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Curtis d'Entremont CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
: 92452 106300 145297 155604 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-06 10:27 EDT by Tod Creasey CLA
Modified: 2007-04-09 14:36 EDT (History)
7 users (show)

See Also:


Attachments
patch (12.58 KB, patch)
2006-06-27 14:27 EDT, Curtis d'Entremont CLA
no flags Details | Diff
updated patch; original is stale (5.29 KB, patch)
2007-01-02 16:47 EST, Curtis d'Entremont CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2006-06-06 10:27:22 EDT
RC7

When using larger font sizes the help viewer still shows standard fonts. I suspect this is an issue of how HTML is displayed - if there is a way to set this please let me know.

STEPS
1) Switch your font to windows extra large in the properties dialog of the OS
2) Start Eclipse
3) Select the System default theme from the Appearance preference page
4) Open the help - fonts are still standard size
Comment 1 Curtis d'Entremont CLA 2006-06-06 10:58:17 EDT
Hmm it seems the doc CSS specifies absolute font sizes (pt).. not sure why. In order to get large fonts here you'll need to tell help to use an external browser and your external browser must be able to scale absolute fonts, and then scale them up in the browser. IE doesn't allow this, but firefox does.

The fix is to change the CSS to not use absolute font sizes.
Comment 2 Curtis d'Entremont CLA 2006-06-06 11:13:53 EDT
*** Bug 145297 has been marked as a duplicate of this bug. ***
Comment 3 Curtis d'Entremont CLA 2006-06-06 11:15:14 EDT
I'm thinking this is something I should fix for 3.2.1.
Comment 4 Tod Creasey CLA 2006-06-06 11:26:31 EDT
+1 from me 
Comment 5 Curtis d'Entremont CLA 2006-06-14 14:59:45 EDT
*** Bug 106300 has been marked as a duplicate of this bug. ***
Comment 6 Curtis d'Entremont CLA 2006-06-27 14:27:59 EDT
Created attachment 45401 [details]
patch

Patch to use relative font sizes in the CSSs. Due to inconsistencies between browsers, the font sizes will be a little different on some platforms, even with default setups. For example, in Safari the fixed width font is a bit smaller than before on my setup, but still readable. I tried using values that worked well on most browsers.

With this fix, all browsers should be able to scale fonts properly. Note: IE does not always adjust properly to the system font settings, so if you have your windows fonts set to large, you may have to also explicitly set it in IE. However it does seem to work when I turn on high contrast mode with large fonts. Firefox seems to work with everything I tested.
Comment 7 Curtis d'Entremont CLA 2006-06-27 14:30:37 EDT
Dejan, could you check in the patch to HEAD ? I don't have access to org.eclipse.platform and org.eclipse.sdk. Will leave this one open for 3.2.1 (branch not yet open for 3.2.1 changes).
Comment 8 Curtis d'Entremont CLA 2006-07-11 18:43:25 EDT
Dejan, could you apply and release to HEAD and the 3.2.1 branch? (I don't have access)
Comment 9 Curtis d'Entremont CLA 2006-08-14 14:10:00 EDT
Didn't get this in early enough in 3.2.1. Should have left more runway to flush out potential problems. Deferring to 3.3.
Comment 10 Chris Goldthorpe CLA 2007-01-02 13:36:39 EST
Are we ready to go ahead and make this change? I'd like to see us switch to using relative font sizes because absolute font sizes work differently between IE and Mozilla and moving to relative fonts would eliminate the problems that occur when users resize their fonts in IE. I'm planning on moving to relative units elsewhere in the Web App. It would be good to do this while we have plenty of time to shake out any side effects. 
Comment 11 Curtis d'Entremont CLA 2007-01-02 16:47:21 EST
Created attachment 56306 [details]
updated patch; original is stale

Dejan, could you apply?
Comment 12 Dejan Glozic CLA 2007-01-08 11:05:14 EST
In HEAD.
Comment 13 Chris Goldthorpe CLA 2007-04-09 14:35:47 EDT
*** Bug 155604 has been marked as a duplicate of this bug. ***
Comment 14 Chris Goldthorpe CLA 2007-04-09 14:36:44 EDT
*** Bug 92452 has been marked as a duplicate of this bug. ***