Community
Participate
Working Groups
3.2 RC3 See also bug 140750 and bug 101033 - contributed ICompletionProposal implementations may not behave correctly. While the CompletionProposalComputer infrastructure protects itself against misbehaving computers, the same is not true for CompletionProposalPopup and AdditionalInfoController. One aspect stands out from the general request in bug 101033: because additional information is now fetched using Jobs, RuntimeExceptions thrown from within the job will cause a dialog to popup, thus cancelling the content assist session. A situation like the one in bug 140750 hence makes content assist unusable. Exceptions in other areas we don't protect against are much less of a problem, since they get simply logged by the SWT message pump, but don't cause the assist session to end.
Created attachment 41086 [details] AdditionalInfoController.java.diff Catches RuntimeExceptions in the additional info job and logs them with severity WARNING, which will still write to the log, but not trigger the pop-up dialog.
Dani, can you request approval?
This is a very useful safty net which we can fix with very low-risk patch. Martin and Philippe, please cast your vote.
+1 for 3.2RC4
Fixed in HEAD. Reviewed by Markus and Tobias. Available in builds >= I20060511-0800.
Verified in I20060511-0800 by intentionally throwing a RuntimeException from a proposal. Verified that the exception gets logged, but that the completion proposal popup stays operational.
