Bug 101033 - [content assist] make content assist infrastructure more robust
Summary: [content assist] make content assist infrastructure more robust
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-21 08:56 EDT by Tom Hofmann CLA
Modified: 2019-09-06 16:07 EDT (History)
1 user (show)

See Also:


Attachments
AdditionalInfoController.java.diff (1.42 KB, patch)
2006-05-10 09:06 EDT, Tom Hofmann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2005-06-21 08:56:02 EDT
3.1-RC2

The content assist infrastructure uses the ICompletionProposal protocol that
allows downstream plug-ins to show proposals. CompletionProposalPopup (and
probably ContextInformationPopup) should 
 - guard itself against misbehaving implementations
 - ensure problems with a proposal implementation get logged
 - ensure content asssist stays operational in the presence of misbehaving
implementations.
Comment 1 Tom Hofmann CLA 2005-06-21 08:56:51 EDT
See also bug 100795 for an example.
Comment 2 Dani Megert CLA 2006-03-21 09:08:16 EST
Has to be shifted to 3.3.
Comment 3 Tom Hofmann CLA 2006-05-10 08:55:38 EDT
See also bug 140750: a run-time exception while computing the additional info renders content assist hardly usable, because the Job infrastructure pops up a dialog every time a proposal is selected.
Comment 4 Tom Hofmann CLA 2006-05-10 09:06:41 EDT
Created attachment 40929 [details]
AdditionalInfoController.java.diff

A patch that protects specifically against RuntimeExceptions thrown in
getAdditionalInfo(IProgressMonitor). These exceptions are worse than others,
because the job infrastructure pops up a dialog whenever an exception occurs,
while exceptions caught by the SWT thread are simply logged, but don't show a
dialog and hence do not interfere with code assist.
Comment 5 Tom Hofmann CLA 2006-05-11 05:18:36 EDT
Separated the additional info issue into bug 141250.
Comment 6 Dani Megert CLA 2006-05-11 05:40:05 EDT
We must revisit the fix for bug 141250 when fixing this one.
Comment 7 Remy Suen CLA 2008-01-10 18:52:14 EST
Will this be looked at in 3.4?
Comment 8 Dani Megert CLA 2008-01-11 03:34:55 EST
>Will this be looked at in 3.4?
Sorry, no resource for this.
Comment 9 Eclipse Webmaster CLA 2019-09-06 16:07:43 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.