Bug 139857 - [Markers] Working set filtering is using infinite depth
Summary: [Markers] Working set filtering is using infinite depth
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.1.2   Edit
Hardware: PC Linux
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on: 162505
Blocks:
  Show dependency tree
 
Reported: 2006-05-02 17:33 EDT by ericsirianni CLA
Modified: 2021-10-18 13:52 EDT (History)
5 users (show)

See Also:


Attachments
Patch (3.85 KB, patch)
2006-06-05 15:55 EDT, Tod Creasey CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ericsirianni CLA 2006-05-02 17:33:53 EDT
"Filter on Working Set" is selected, but the problems panel does not filter out problems on resources not in the working set.  No "refresh tricks" seem to fix it (opening closing the view, etc.).

It seems to be an error in how the hierarchy is treated.  If I de-select the grandparent package in the working set, then errors on the child package do not show up, but de-selecting just the child package is not sufficient.
Comment 1 Markus Keller CLA 2006-05-03 10:27:11 EDT
Eric, can you give a concrete example how your project and your working set looks like?
Comment 2 ericsirianni CLA 2006-05-03 11:20:55 EDT
Sure.

Create a new project with packages 
com.foo
com.foo.bar
com.foo.baz

Create a Java working set with "com.foo" and "com.foo.baz" selected.  
Create a file Test.java in com.foo
Create a file Warnings.java in com.foo.bar that contains an error.
Filter the Problems view by that working set - you'll still see the error show up, even though that package "com.foo.bar" is not in the working set.
Comment 3 Markus Keller CLA 2006-05-03 16:07:09 EDT
Reproduced in 3.2RC2. The Navigator view correctly hides Test.java, so I think this is a problem in the Problems view.
Comment 4 Ross Stenersen CLA 2006-06-02 15:11:15 EDT
I have been having this issue also.  I am currently using 3.2RC5 on Windows XP.  It's really buggin' me too because we have some generated code that is full of warnings and I wanted to use a working set that includes all but the generated code for my filter but alas, it has no effect.
Comment 5 Tod Creasey CLA 2006-06-05 15:28:44 EDT
The problem is the following code

IMarker[] markers = resource.findMarkers(markerType.getId(),						includeAllSubtypes.contains(markerType), depth);

All of the children of the com.foo package will be included if we have it in the list as we are talking in terms of resources not working sets.

Removing the 3.2.1 tag as this was an issue in 3.1.2 and it is only in a specific case. I'll need some help from Kim to consider a better strategy as working sets and resource trees are colliding here.
Comment 6 John Arthorne CLA 2006-06-05 15:37:12 EDT
CCing Michael - this is a logical->physical mapping problem.  It sounds like ResourceTraversal.findMarkers should be used instead.
Comment 7 Tod Creasey CLA 2006-06-05 15:55:24 EDT
Created attachment 43519 [details]
Patch

Here is a patch implementing John's suggestion. With this patch applied we get the same behaviour so I am not sure a ResourceTraversal will behave any differently
Comment 8 John Arthorne CLA 2006-06-05 16:15:32 EDT
Sorry, I didn't explain it very well. It would need to obtain the traversal from the model object (java package).  I'll let MV chime in with the details.
Comment 9 Michael Valenta CLA 2006-06-06 13:41:17 EDT
The ResourceMapping#findMarkers method allows the model to determine which markers apply the the model object represented by the mapping. When the markers for a selection are being shown, the problems view should adapt the selected elements to ResourceMapping and then call the findMarkers method on the resulting mappings to determine which markers are visible.
Comment 10 Susan McCourt CLA 2009-07-15 12:17:06 EDT
"As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009"
Comment 11 Eclipse Webmaster CLA 2019-09-06 16:03:34 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 12 Eclipse Genie CLA 2021-10-18 13:52:02 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.