Community
Participate
Working Groups
I20060321-1210 The attached patch converts the Text search page and the Replace dialog to the new field assist story. I did not yet release it because it reveals layout problems as already raised in bug . While this is easy to fix for the Replace dialog (AFAIK there's API to get the size of the cue) it will be hard for the Text Search page: because the find field of the other contributed pages are no longer at the same location and because we can't force all search page contributors to change their layout, the Search dialog becomes noisy when switching between pages. Adding Susan to comment about to resolve this issue.
>raised in bug . That should have been "raised in bug 124873." >Adding Susan to comment about to resolve this issue. Should read: "Adding Susan to comment about how to resolve this issue.
Created attachment 36740 [details] Patch that does the conversion but has bad layout
See also bug #131002 which discusses adding the required field indicators to the search dialog. The required field indicators also affect the alignment of the fields across search pages, so I feel that over time contributors will have room for decorations on their pages. For example, putting the required field indicator on the file name pattern field of the file search dialog will once again align those fields. I think there may be some layout noise between pages while all these issues are sorted out, but I find that in the case of search pages, the layouts (particularly the find field widths) move around enough that as long as each page is nicely aligned within itself, it's not a huge issue.
Created attachment 36836 [details] patch that includes Dani's conversion + required field emphasis "Fixes" layout problem by also adding required field emphasis.
Created attachment 36855 [details] patch with regex content assist and required field emphasis altered layout of dialog based on discussion with Kim Peter. The first patch indented the check box to line it up with the decorated fields. This had the effect of making it look like it belonged to the text above it. Instead, we added vertical space above checkbox and purposely did not align checkbox with the text fields so it would not appear to be indented.
Created attachment 37362 [details] patch with regex content assist and alignment of lower field this patch aligns the two text boxes within the file search page (no required field emphasis)
Should copy over the latest regex support from the Find/Replace dialog when bug 80667 and bug 44422 are reviewed/released.
>Should copy over the latest regex support from the Find/Replace dialog when bug >80667 and bug 44422 are reviewed/released. There's now a public FindReplaceDocumentAdapterContentProposalProvider. I've simplified the RegExContentAssistProcessor to use that one. If Search/Martin decides to switch to the JFace field assist support this can be simply removed and the FindReplaceDocumentAdapterContentProposalProvider be used to get the content proposals.
fixed > 20080425.
