Bug 131002 - Search Dialog - consider using the new required field indicators
Summary: Search Dialog - consider using the new required field indicators
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Search-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-08 18:54 EST by Susan McCourt CLA
Modified: 2019-09-06 15:36 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2006-03-08 18:54:56 EST
I've opened this bug based on the work done in bug #120238.  There is now a graphic design and support for showing required field emphasis in dialogs.  I think search dialogs would benefit from this because the different search pages are a bit inconsistent in what is required.  

The file pattern field is required in file search, but the search expression is not required.  In Java search, the search expression is required.  In plug-in search, nothing is required. 

I realize this crosses platform and JDT boundaries, but figured I'd open the bug here.  If you are interested in this idea, I could provide patches for the search pages involved.
Comment 1 Martin Aeschlimann CLA 2006-03-09 10:37:24 EST
Susan, can you point me to the example code? 
Comment 2 Susan McCourt CLA 2006-03-09 13:42:18 EST
The example is in org.eclipse.ui.examples.fieldassist.
To run the example, choose FieldAssist>Open Example Dialog.
There is a preference page that lets you control what kinds of emphasis is shown, but by default it uses the color and decoration specified by Kim in bug #120238.

The code is in the class ExampleDialog.  For required field emphasis, the methods of importance are handleFocusLost(SmartField) and handleModify(SmartField.)

The intention is to some day have code in JFace that would allow you to specify a field is required and everything would happen for you.  But for now, it's up to the individual dialog and you can factor the code however you wish.
Comment 3 Susan McCourt CLA 2006-03-22 16:46:35 EST
Martin, per bug #120238, I'm going to add required field emphasis to the switch workspace dialog and elsewhere.  I will ping here when there is something more specific for you to look at.
Comment 4 Susan McCourt CLA 2006-03-23 14:49:20 EST
See the patch in bug #132833 which adds required field emphasis to the text search page as well as the regex content assist cue.  These fixes are included together as both involve adding decorated fields and with only one fix, code to fix the alignment has to be added. 

If you prefer to only consider required field emphasis and not the content assist cue support, then I can provide a different patch here.  Let me know.
Comment 5 Eclipse Webmaster CLA 2019-09-06 15:36:22 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.