Bug 105262 - [BIDI] need to add $nl$/ to icon paths for reversed icons
Summary: [BIDI] need to add $nl$/ to icon paths for reversed icons
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 105008
  Show dependency tree
 
Reported: 2005-07-26 22:17 EDT by Karice McIntyre CLA
Modified: 2005-09-26 11:45 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karice McIntyre CLA 2005-07-26 22:17:25 EDT
Target for 3.1.1 release (NL release).

In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as 
if the icon has been reversed.  For all plugins that supply icons, some code 
changes are required to support this that do not appear to be present when 
running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with 
program argument -nl ar_EG).  The following 2 items need to be checked:
1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ 
(e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml.
2. Must use Platform.find(Bundle, Path) to create the URL that is used to 
create the image descriptor.
See Tod's Eclipse blog entry for more details on the code changes required. 
http://todcreaseyeclipse.blogspot.com/

NOTE: Only icons that have the possibility of being flipped need to have this 
prefix added - you can leave the paths of other icons as they are for 3.1.1 if 
you want to keep changes to a minimum.  You can get the BiDi nl fragments from 
Cam-Thu Le so that you can see which of your icons have a reversed counterpart 
in BiDi locales.  

The following plugins of this component have been identified as requiring this 
check:
*org.eclipse.team.cvs.ui 

Questions about this issue can be directed to Karice McIntyre or Tod Creasey.
Comment 1 Mike Wilson CLA 2005-07-27 11:27:53 EDT
Michael V. is on holidays until Aug. 4'th. He will address this when returns.
Comment 2 Michael Valenta CLA 2005-08-03 11:59:11 EDT
The required CVS plugin changes were made in 3.1. I did clean up the code a 
bit for 3.2 but nothing needs to be backported to 3.1.1 for this. However, 
changes are required to the Team UI plugin which impact CVS UI. These will be 
done as part of bug 105263.
Comment 3 Michael Valenta CLA 2005-09-26 11:45:55 EDT
Verified fixed in M20050923-1430