Community
Participate
Working Groups
Target for 3.1.1 release (NL release). In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as if the icon has been reversed. For all plugins that supply icons, some code changes are required to support this that do not appear to be present when running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with program argument -nl ar_EG). The following 2 items need to be checked: 1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ (e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml. 2. Must use Platform.find(Bundle, Path) to create the URL that is used to create the image descriptor. See Tod's Eclipse blog entry for more details on the code changes required. http://todcreaseyeclipse.blogspot.com/ NOTE: Only icons that have the possibility of being flipped need to have this prefix added - you can leave the paths of other icons as they are for 3.1.1 if you want to keep changes to a minimum. You can get the BiDi nl fragments from Cam-Thu Le so that you can see which of your icons have a reversed counterpart in BiDi locales. The following plugins of this component have been identified as requiring this check: *org.eclipse.search Questions about this issue can be directed to Karice McIntyre or Tod Creasey.
Created attachment 25347 [details] patch
Tom and Dirk, can your rewiew?
Reviewed by Tom
released for 3.1.1 and 3.2 HEAD, with the exception of changes to plugin.xml (have to be sure that all used extension points have updated their way of loading images)
Created attachment 25401 [details] patch Update analogue to bug 105254 (no 'missing' image for disabled actions). Tom and Dirk, can you review?
patch reviewed, ok.
Patch reviewed. +1.
patch released in 3.1.1 and 3.2 streams
plugin.xml has now been updated as well (for M20050803)
Verifying...
Verified in M20050804-1200.