Bug 105260 - [BIDI] need to add $nl$/ to icon paths for reversed icons
Summary: [BIDI] need to add $nl$/ to icon paths for reversed icons
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 105008
  Show dependency tree
 
Reported: 2005-07-26 22:14 EDT by Karice McIntyre CLA
Modified: 2005-08-09 04:47 EDT (History)
2 users (show)

See Also:


Attachments
patch (13.81 KB, patch)
2005-07-27 08:39 EDT, Martin Aeschlimann CLA
no flags Details | Diff
patch (4.71 KB, patch)
2005-07-28 05:53 EDT, Martin Aeschlimann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karice McIntyre CLA 2005-07-26 22:14:10 EDT
Target for 3.1.1 release (NL release).

In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as 
if the icon has been reversed.  For all plugins that supply icons, some code 
changes are required to support this that do not appear to be present when 
running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with 
program argument -nl ar_EG).  The following 2 items need to be checked:
1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ 
(e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml.
2. Must use Platform.find(Bundle, Path) to create the URL that is used to 
create the image descriptor.
See Tod's Eclipse blog entry for more details on the code changes required. 
http://todcreaseyeclipse.blogspot.com/

NOTE: Only icons that have the possibility of being flipped need to have this 
prefix added - you can leave the paths of other icons as they are for 3.1.1 if 
you want to keep changes to a minimum.  You can get the BiDi nl fragments from 
Cam-Thu Le so that you can see which of your icons have a reversed counterpart 
in BiDi locales.  

The following plugins of this component have been identified as requiring this 
check:
*org.eclipse.search

Questions about this issue can be directed to Karice McIntyre or Tod Creasey.
Comment 1 Martin Aeschlimann CLA 2005-07-27 08:39:44 EDT
Created attachment 25347 [details]
patch
Comment 2 Martin Aeschlimann CLA 2005-07-27 08:41:09 EDT
Tom and Dirk, can your rewiew?
Comment 3 Martin Aeschlimann CLA 2005-07-27 09:05:23 EDT
Reviewed by Tom
Comment 4 Martin Aeschlimann CLA 2005-07-27 09:43:59 EDT
released for 3.1.1 and 3.2 HEAD, with the exception of changes to plugin.xml
(have to be sure that all used extension points have updated their way of
loading images)



Comment 5 Martin Aeschlimann CLA 2005-07-28 05:53:32 EDT
Created attachment 25401 [details]
patch

Update analogue to bug 105254 (no 'missing' image for disabled actions).
Tom and Dirk, can you review?
Comment 6 Tom Hofmann CLA 2005-07-28 06:05:53 EDT
patch reviewed, ok.
Comment 7 Dirk Baeumer CLA 2005-07-29 07:02:06 EDT
Patch reviewed. +1.
Comment 8 Martin Aeschlimann CLA 2005-07-29 09:44:34 EDT
patch released in 3.1.1 and 3.2 streams
Comment 9 Martin Aeschlimann CLA 2005-08-03 06:56:10 EDT
plugin.xml has now been updated as well (for M20050803)
Comment 10 Dani Megert CLA 2005-08-09 04:33:35 EDT
Verifying...
Comment 11 Dani Megert CLA 2005-08-09 04:47:57 EDT
Verified in M20050804-1200.